Fixes a I18N_ARGUMENT_MISSING warning in the ui that appears sometimes while discover is looking for updates.
Details
Details
- Reviewers
- None
- Group Reviewers
Discover Software Store
Version numbers are still displayed, and no warnings are visible
Diff Detail
Diff Detail
- Repository
- R134 Discover Software Store
- Branch
- updates-page-i18n-versions (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 11565 Build 11583: arc lint + arc unit
Comment Actions
The explanation of this change does not match the code changes: the code never translated the version numbers, but it composed a string showing the version numbers before and after the upgrade.
Could it simply be that one of the two (for example installedVersion) is null?
| discover/qml/UpdatesPage.qml | ||
|---|---|---|
| 239 | I do not think this change is correct: "%1 → %2" is a UI string, and thus it must be translatable. | |
Comment Actions
Yep, change isn't correct. A solution would be to ad an installedVersion && availableVersion ? i18n(...) : "".
Or fix i18n() to not complain about "", although I'm pretty sure it's not easily doable.