Convert from virtual+Q_DECL_OVERRIDE to override.
ClosedPublic

Authored by shlomif on May 3 2019, 6:58 PM.

Details

Reviewers
aacid
Group Reviewers
KDE Games
Summary

Per the commentary on https://phabricator.kde.org/D20892 - C++11.

Diff Detail

Repository
R410 KPatience
Branch
q-decl-override
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 11518
Build 11536: arc lint + arc unit
shlomif created this revision.May 3 2019, 6:58 PM
Restricted Application added a reviewer: KDE Games. · View Herald TranscriptMay 3 2019, 6:58 PM
Restricted Application added a subscriber: kde-games-devel. · View Herald Transcript
shlomif requested review of this revision.May 3 2019, 6:58 PM

The you can also update your minimum Qt version to 5.9 - currently you've 5.7 which still supports gcc 4.6 which does not support 'override' so this requirement is no longer needed and can go away :)

aacid accepted this revision.May 8 2019, 10:53 PM
aacid added a subscriber: aacid.

@chehrlic we don't really need to increase the Qt version though, do we?

I mean you can just build fine with Qt 5.7 and C++11

This revision is now accepted and ready to land.May 8 2019, 10:53 PM
shlomif closed this revision.Jun 1 2019, 12:13 PM

Merged, thanks!