Details
Details
Diff Detail
Diff Detail
- Repository
- R410 KPatience
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| patsolve/abstract_fc_solve_solver.h | ||
|---|---|---|
| 28–37 | remove virtual keyword. | |
Comment Actions
Q_DECL_OVERRIDE is a nop on compilers that don't support override. So this will make the functions non virtual in that case. The original revision did not have this problem. Please test this on such a compiler.
| patsolve/abstract_fc_solve_solver.h | ||
|---|---|---|
| 28–37 | Use overide directly or these functions will be none virtual on compilers that don't support overide. | |
| patsolve/abstract_fc_solve_solver.h | ||
|---|---|---|
| 28–37 | that's not correct, these functions are virtual because the functions in Solver are virtual, you don't need to specify virtual in child classes, only override. What should be used is override instead of Q_DECL_OVERRIDE, it's long time since we stopped supporting compilers that don't support override. | |