Differential D20982

[TagsFileItemAction] Only show action when file is writable
ClosedPublic
Actions

Authored by bruns on May 3 2019, 1:47 AM.

Details

Reviewers
nicolasfella
ngraham
Group Reviewers
Baloo
Dolphin
Commits
R824:303e815f3e34: [TagsFileItemAction] Only show action when file is writable
R824:08b42f9579af: [TagsFileItemAction] Only show action when file is writable
Summary

When a file is read-only, tags can neither be added nor removed, and
trying to do so fails silently.

Test Plan

open context menu on readonly file

Diff Detail

Repository
R824 Baloo Widgets
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bruns created this revision.May 3 2019, 1:47 AM
Restricted Application added a project: Baloo. · View Herald TranscriptMay 3 2019, 1:47 AM
bruns requested review of this revision.May 3 2019, 1:47 AM
ngraham accepted this revision.May 3 2019, 1:54 AM
This revision is now accepted and ready to land.May 3 2019, 1:54 AM
Closed by commit R824:08b42f9579af: [TagsFileItemAction] Only show action when file is writable (authored by bruns). · Explain WhyMay 3 2019, 1:56 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 57431

View Options

src/tagsfileitemactionplugin/tagsfileitemaction.cpp

Loading...