Currently, when selecting a language in the "Highlighting" menu, the "Mode" menu stops working.
This happens because, the Modes don't apply if m_hlSetByUser is true (if the user has chosen a Highlight in the menu).
This is swelling and I think it's better to change it.
Now when selecting a Mode, the "Highlighting" menu is also updated (but, when choosing an item in the Highlighting menu, the "Mode" menus don't change).
Details
Details
- Reviewers
cullmann - Group Reviewers
KTextEditor Kate - Commits
- R39:0a6ea0624228: Allow to change the Mode, after changing the Highlighting
Diff Detail
Diff Detail
- Repository
- R39 KTextEditor
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
The function setDontChangeHlOnSave() uses the m_hlSetByUser variable to avoid resetting the syntax highlighting, which I removed in updateFileType().
I could use another binary for this.
src/document/katedocument.cpp | ||
---|---|---|
1893 | Apparently, the problem is here. "m_hlSetByUser" is used to avoid resetting the hl. I should create another binary varible for this. |
Comment Actions
errata: the setDontChangeHlOnSave() function has nothing to do here.
more time I upload a patch.