Differential D21331

Fix: don't reset Highlight when saving some files
ClosedPublic
Actions

Authored by nibags on May 22 2019, 9:02 AM.

Details

Reviewers
cullmann
Group Reviewers
KTextEditor
Commits
R39:b2064042daa1: Fix: don't reset Highlight when saving some files
Summary

BUG: 407763

Fix the regression of patch D20959.

In sftp:// or fish:// files, the current syntax highlighting isn't stored in $HOME/.config/katemetainfos.
Therefore, when saving a file, the highlighting is reset.
This only happens when changing the hl from the "Highlighting" menu, not from the "Mode" menu.

Basically, this returns to the state before the patch D20959, but now the highlight will always change if user is true.

Diff Detail

Repository
R39 KTextEditor
Branch
fix-save-hl
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 12047
Build 12065: arc lint + arc unit
nibags created this revision.May 22 2019, 9:02 AM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptMay 22 2019, 9:02 AM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
nibags requested review of this revision.May 22 2019, 9:02 AM
cullmann accepted this revision.May 22 2019, 9:46 AM

Lets give this a try.

This revision is now accepted and ready to land.May 22 2019, 9:46 AM
nibags closed this revision.May 22 2019, 11:25 AM

Revision Contents
Changeset List

PathPackages
Msrc/document/katedocument.cpp (6 lines)

Diff 58458

View Options

src/document/katedocument.cpp

Loading...