doing something with return values of methods marked with REQUIRED_RESULT
Details
compile and run make test
no compile warnings for me now
Diff Detail
- Repository
- R174 KContacts
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
src/converter/ldifconverter.cpp | ||
---|---|---|
114–121 | this will now return the result of the last contactGroupToLDIF call -- so, if contactGroupToLDIF returns false for any element but last of the list, the result is still true (like the current code, though) IMHO there are two options: | |
126–133 | ditto |
src/converter/ldifconverter.cpp | ||
---|---|---|
114–121 | right. my reason for this bad code was that I was following other patterns in the file. I think the return value should matter and we should do: except I don't know what that will break. |
src/converter/ldifconverter.cpp | ||
---|---|---|
122 | You could simplify by using result |= contactGroupToLDIF(*it, str) |
src/converter/ldifconverter.cpp | ||
---|---|---|
122 | I could. but I don't want to :) |