- Port to QQC2+Kirigami FormLayout (except for the mimetype table, there is no QQC2 equivalent)
- Improve some strings
- Follow the KDE HIG
- Improve look of buttons and other controls
Details
Details
- Reviewers
davidedmundson filipf ngraham - Group Reviewers
Plasma VDG - Maniphest Tasks
- T10586: Modernize widget configuration settings
- Commits
- R119:4c6a6fe1870e: [containments/desktop] Port desktop settings pages to QQC2+Kirigami FormLayout…
Configure a Folder View widget and go through the three settings pages.
Diff Detail
Diff Detail
- Repository
- R119 Plasma Desktop
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
One comment, please include when committing
| containments/desktop/package/contents/ui/ConfigFilter.qml | ||
|---|---|---|
| 32–33 | These lines are quite wrong to begin with, but resizing childenRect inside a columnLayout now becomes doubly wrong. It's a clear binding loop as children are resized to the layout. If you don't have a tonne of warnings being printed, it probably means these properties get override by the instantiator of this Item. Please kill them. | |
Comment Actions
Works fine and looks good to me. This is probably a style issue, but it should be noted that these buttons shouldn't stay highlighted after they're pressed:
| containments/desktop/package/contents/ui/ConfigLocation.qml | ||
|---|---|---|
| 199 ↗ | (On Diff #57144) | Personally I don't think we need this indent as the enabled property already gives a clue what the text field is related to, but it's not particularly important one way or another. |
Comment Actions
Works fine and looks good to me. This is probably a style issue, but it should be noted that these buttons shouldn't stay highlighted after they're pressed:
Can't do much about that and it's like this for other buttons as well. It goes away after you click something else though, I think it isn't that bad.
| containments/desktop/package/contents/ui/ConfigLocation.qml | ||
|---|---|---|
| 199 ↗ | (On Diff #57144) | This is the correct way and like this in other places such as the Fonts KCM too. |
| containments/desktop/package/contents/ui/ConfigFilter.qml | ||
|---|---|---|
| 208 | I think using ToolTip attached property is discouraged as that cannot inherit the default times from the desktop style. ToolTip {
...
} | |