Fix KBoomarkMenuTest when Bookmarks Editor is not installed. The test
depended on the Bookmarks Editor being installed.
Details
Details
Diff Detail
Diff Detail
- Repository
- R294 KBookmarks
- Branch
- fix_kboomarkmenutest_without_bookmarks_editor (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 11296 Build 11314: arc lint + arc unit
Comment Actions
Thanks for the debugging. Looks good, just minor coding style issues.
| autotests/kbookmarkmenutest.cpp | ||
|---|---|---|
| 42 | prepend static (good practice in general so the symbol isn't exported, although in a test program it doesn't make much difference). It becomes a readability difference to me, if I don't see static I wonder which other file wants to call this. | |
| 44 | This code could put the result into a (local) static bool variable, to cache the result, but no big deal for a unittest. | |
| 47 | prepend static | |
| 52 | prepend static | |