Differential D20814

find netcdf via its own cmake config
ClosedPublic
Actions

Authored by sitter on Apr 25 2019, 1:21 PM.

Details

Reviewers

apol

Commits

R262:136b252dc92b: find netcdf via its own cmake config

Summary

no need to manually find it. cmake configs are vastly more reliable.

Test Plan

still builds

Diff Detail

Repository

R262 LabPlot

Branch

netcdf

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 11219
Build 11237: arc lint + arc unit

sitter created this revision.Apr 25 2019, 1:21 PM

Restricted Application added a project: KDE Edu. · View Herald TranscriptApr 25 2019, 1:21 PM

Restricted Application added a subscriber: kde-edu. · View Herald Transcript

sitter requested review of this revision.Apr 25 2019, 1:21 PM

Harbormaster completed remote builds in B11219: Diff 56966.Apr 25 2019, 1:21 PM

sitter added a dependency: D20807: add support for extra cmake finders.Apr 25 2019, 1:21 PM

LGTM

This revision is now accepted and ready to land.Apr 25 2019, 3:53 PM

Closed by commit R262:136b252dc92b: find netcdf via its own cmake config (authored by sitter). · Explain WhyApr 26 2019, 9:36 AM

This revision was automatically updated to reflect the committed changes.

There is no "FindnetCDF.cmake":

CMake Warning at CMakeLists.txt:265 (FIND_PACKAGE):

By not providing "FindnetCDF.cmake" in CMAKE_MODULE_PATH this project has
asked CMake to find a package configuration file provided by "netCDF", but
CMake did not find one.

This revision is now accepted and ready to land.Apr 26 2019, 9:45 PM

netcdf ships with a cmake config for a while now.

Meaning the file netCDFConfig.cmake installed by netcdf itself is used to find the lib/include stuff, no finder script necessary.

netCDFConfig.cmake is not available at least on OpenSUSE and Fedora (any version). Also a ./configure && make install of the latest version does not install the file.

https://www.unidata.ucar.edu/software/netcdf/docs/getting_and_building_netcdf.html#netCDF-CMake

Apparently netcdf may be built with cmake or autotools, but the latter won't install all the files the former will 🤕

I suppose we can take the same route as for cantor (use config and fall back to finder if no config is present). I'll get on it on Monday.

Closing again. https://phabricator.kde.org/D20891

Revision Contents
Changeset List

			Path	Packages
M			CMakeLists.txt (21 lines)
M			src/CMakeLists.txt (4 lines)
M			tests/import_export/ASCII/CMakeLists.txt (4 lines)
M			tests/import_export/JSON/CMakeLists.txt (4 lines)
M			tests/import_export/MQTT/CMakeLists.txt (4 lines)
M			tests/import_export/project/CMakeLists.txt (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	56966	87cfdbb		Apr 25 2019, 1:21 PM	★	★
Diff 2	57016	ecd9a31	R262:136b252dc92bf98bb71870e59fd8767388030ff3	Apr 26 2019, 9:36 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
e8b7f810f14e	d10d7baa34d1	87cfdbbbbb01	Harald Sitter	find netcdf via its own cmake config (Show More…)	Apr 24 2019, 11:42 AM

Status	Author	Revision
Closed	sitter	D20808 find cantor via config (and fall back to finder when not available)
Closed	sitter	D20809 replace manual cerf lookup with pkg-config-assisted finder
Closed	sitter	D20811 replace manual fftw3 lookup with pkg-config-assisted finder
Closed	sitter	D20812 import cfitsio finder from gwenview and use it instead of manual find_*
Closed	sitter	D20813 replace manual lz4 lookup with pkg-config-assisted finder
Closed	sitter	D20814 find netcdf via its own cmake config
Closed	sitter	D20807 add support for extra cmake finders