Differential D20730

Change default window actions modifier key to Meta
AbandonedPublic
Actions

Authored by GB_2 on Apr 22 2019, 10:37 AM.

Details

Reviewers

Group Reviewers

KWin
VDG

Summary

BUG: 399375

This patch changes the default window actions modifier key to Meta instead of Alt, because Alt causes problems in a lot of very popular and professional software such as Blender, GIMP, Inkscape, Krita, Gravit, Shotcut or even Krita! It prevents you from using some functions in those programs. We already use Meta for a lot of things such as window tiling, so we should use it for the window actions modifier too. In general, Meta should be used in global/shell shortcuts. GNOME changed it in the past too because of those reasons. If this default will get changed we should also announce it in the next Plasma release notes to make people aware about this change.

Test Plan

Delete the default KWin config files and try using Meta+Click to move a window.

Diff Detail

Repository

R108 KWin

Branch

change-default-window-actions-modifier-key-to-meta (branched from master)

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 11092
Build 11110: arc lint + arc unit

GB_2 created this revision.Apr 22 2019, 10:37 AM

Restricted Application added a project: KWin. · View Herald TranscriptApr 22 2019, 10:37 AM

Restricted Application added a subscriber: kwin. · View Herald Transcript

GB_2 requested review of this revision.Apr 22 2019, 10:37 AM

Harbormaster completed remote builds in B11092: Diff 56719.Apr 22 2019, 10:37 AM

You can't break the behaviour for every KDE user.

Existing users come first.

This revision now requires changes to proceed.Apr 22 2019, 10:40 AM

In D20730#454030, @davidedmundson wrote:

You can't break the behaviour for every KDE user.

Existing users come first.

We cannot kill usability just for the sake of familiarity. Should we instead change this default only on new installs?

Revision Contents
Changeset List

			Path	Packages
M			autotests/integration/decoration_input_test.cpp (4 lines)
M			autotests/integration/internal_window.cpp (4 lines)
M			autotests/integration/pointer_constraints_test.cpp (2 lines)
M			autotests/integration/pointer_input.cpp (10 lines)
M			kcmkwin/kwinoptions/mouse.cpp (4 lines)
M			kwin.kcfg (2 lines)
M			options.cpp (4 lines)