johanneszarl (Johannes Zarl-Zierl)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Aug 1 2016, 4:35 PM (163 w, 6 d)
Availability
Available

Recent Activity

Tue, Sep 17

johanneszarl committed R463:666c8a3f26c7: Fix i18n typo. (authored by johanneszarl).
Fix i18n typo.
Tue, Sep 17, 10:08 PM
johanneszarl committed R463:a5441d45f44d: MapView: alter status label size dynamically. (authored by johanneszarl).
MapView: alter status label size dynamically.
Tue, Sep 17, 10:08 PM
johanneszarl committed R463:4a7d403e17f2: Remove PositionBrowserWidget (authored by johanneszarl).
Remove PositionBrowserWidget
Tue, Sep 17, 9:54 PM
johanneszarl committed R463:b8f5f1d0c4ee: Add MapView::addImages() (authored by johanneszarl).
Add MapView::addImages()
Tue, Sep 17, 9:54 PM
johanneszarl committed R463:c047130e23c2: Add credits for Matthias Füssel. (authored by johanneszarl).
Add credits for Matthias Füssel.
Tue, Sep 17, 9:54 PM
johanneszarl committed R463:d8157710ea82: Clean up includes. (authored by johanneszarl).
Clean up includes.
Tue, Sep 17, 9:54 PM
johanneszarl committed R463:5de6e44b100b: Eliminate method MainWindow::Window::createPositionBrowser (authored by johanneszarl).
Eliminate method MainWindow::Window::createPositionBrowser
Tue, Sep 17, 9:54 PM
johanneszarl committed R463:6cd811658c97: Fix 0 usage instead of nullptr. (authored by johanneszarl).
Fix 0 usage instead of nullptr.
Tue, Sep 17, 9:54 PM
johanneszarl committed R463:c5393ed35770: Cosmetic changes (variable naming). (authored by johanneszarl).
Cosmetic changes (variable naming).
Tue, Sep 17, 9:54 PM
johanneszarl committed R463:fd7e0b8107a8: Add timings for Browser::PositionBrowserWidget. (authored by johanneszarl).
Add timings for Browser::PositionBrowserWidget.
Tue, Sep 17, 9:54 PM

Sun, Sep 15

johanneszarl committed R463:519d41c314b5: Add timings for Browser::PositionBrowserWidget. (authored by johanneszarl).
Add timings for Browser::PositionBrowserWidget.
Sun, Sep 15, 9:47 PM
johanneszarl committed R463:af60a2ed5476: MapView: Use enum class instead of plain enum. (authored by johanneszarl).
MapView: Use enum class instead of plain enum.
Sun, Sep 15, 9:31 PM
johanneszarl committed R463:019b76f7b316: AnnotationDialog: make context menu of mapDock available. (authored by johanneszarl).
AnnotationDialog: make context menu of mapDock available.
Sun, Sep 15, 9:31 PM

Sat, Sep 14

johanneszarl committed R463:ddbd391bdaac: Set C++ standard to C++14. (authored by johanneszarl).
Set C++ standard to C++14.
Sat, Sep 14, 10:30 PM
johanneszarl committed R463:c38f51365a0e: Refactor: convert to new signal-connection style. (authored by johanneszarl).
Refactor: convert to new signal-connection style.
Sat, Sep 14, 10:30 PM
johanneszarl committed R463:9e4cf80f95a6: Mark KIPI plugins as legacy plugins. (authored by johanneszarl).
Mark KIPI plugins as legacy plugins.
Sat, Sep 14, 12:01 AM

Fri, Sep 13

johanneszarl committed R463:5ec4b5b52ae4: Refactor: convert old-style connect in StatusBar. (authored by johanneszarl).
Refactor: convert old-style connect in StatusBar.
Fri, Sep 13, 11:39 PM

Wed, Sep 11

johanneszarl added a comment to T11214: Running clang-format across all plasma (and potentially over repos).

The question is whether you really need the ColumnLimit - if you set a ColumnLimit of 0, clang-format won't reflow continuations like in Nate's first screenshot.
For Nate's second suggestion, BreakConstructorInitializers and BreakInheritanceList should produce more readable formatting.
I'm not sure which option can be used to fix the Enum formatting, but with ColumnLimit set to 0 at least the existing enums shouldn't be butchered, I guess...

Wed, Sep 11, 8:33 PM

Tue, Sep 10

johanneszarl committed R463:640d2bdd4698: Refactor: convert to new signal-connection style. (authored by johanneszarl).
Refactor: convert to new signal-connection style.
Tue, Sep 10, 10:00 PM
johanneszarl committed R463:b93f2dfa8dbb: Remove useless code (no longer needed workaround). (authored by johanneszarl).
Remove useless code (no longer needed workaround).
Tue, Sep 10, 10:00 PM
johanneszarl committed R463:e69f532a969e: Refactor: convert to new signal-connection style. (authored by johanneszarl).
Refactor: convert to new signal-connection style.
Tue, Sep 10, 10:00 PM
johanneszarl committed R463:a8b69951067f: Refactor replace some 0 values with nullptr. (authored by johanneszarl).
Refactor replace some 0 values with nullptr.
Tue, Sep 10, 10:00 PM
johanneszarl committed R463:01a59e3d9e06: Refactor: convert to new signal-connection style. (authored by johanneszarl).
Refactor: convert to new signal-connection style.
Tue, Sep 10, 10:00 PM

Mon, Sep 9

johanneszarl committed R463:227b896b079f: Refactor: convert to new signal-connection style. (authored by johanneszarl).
Refactor: convert to new signal-connection style.
Mon, Sep 9, 9:36 PM
johanneszarl committed R463:a619be424c29: Refactor: convert more connect statements to new syntax. (authored by johanneszarl).
Refactor: convert more connect statements to new syntax.
Mon, Sep 9, 9:36 PM

Sun, Sep 8

johanneszarl committed R463:58594fafe9f4: Batch refactor: convert to new connect style. (authored by johanneszarl).
Batch refactor: convert to new connect style.
Sun, Sep 8, 8:59 PM

Wed, Sep 4

johanneszarl committed R463:048e6457c6ec: Fix spurious CI warning on kf5-qt5 SUSEQt5.12 (authored by johanneszarl).
Fix spurious CI warning on kf5-qt5 SUSEQt5.12
Wed, Sep 4, 9:53 PM

Tue, Sep 3

johanneszarl committed R463:ea78977b7a3e: DescriptionUtils/timeAgo(): fix minTimeAgo and maxTimeAgo (authored by johanneszarl).
DescriptionUtils/timeAgo(): fix minTimeAgo and maxTimeAgo
Tue, Sep 3, 10:35 PM
johanneszarl committed R463:d7cb10fee5de: Disable debug code. (authored by johanneszarl).
Disable debug code.
Tue, Sep 3, 10:15 PM
johanneszarl committed R463:6be46c5054e7: Add i18n context to DescriptionUtils::timeAgo and formatAge. (authored by johanneszarl).
Add i18n context to DescriptionUtils::timeAgo and formatAge.
Tue, Sep 3, 10:15 PM
johanneszarl committed R463:665beab22d37: Allow different localisation of birthdays vs. anniversaries. (authored by johanneszarl).
Allow different localisation of birthdays vs. anniversaries.
Tue, Sep 3, 10:15 PM
johanneszarl committed R463:275a43a67aa9: Make formatDate a method of AgeSpec. (authored by johanneszarl).
Make formatDate a method of AgeSpec.
Tue, Sep 3, 10:15 PM
johanneszarl committed R463:3fbf2f3f1e7c: Replace DateSpec=QPair<int,char> with custom class. (authored by johanneszarl).
Replace DateSpec=QPair<int,char> with custom class.
Tue, Sep 3, 10:15 PM

Mon, Sep 2

johanneszarl committed R463:3e6ff502b8d4: Api documentation. (authored by johanneszarl).
Api documentation.
Mon, Sep 2, 9:58 PM
johanneszarl committed R463:b2840a1c3d15: Swap time range in DescriptionUtils::timeAgo (authored by johanneszarl).
Swap time range in DescriptionUtils::timeAgo
Mon, Sep 2, 9:58 PM
johanneszarl committed R463:c28b3f6229c0: Use existing functions for implementing timeAgo(). (authored by johanneszarl).
Use existing functions for implementing timeAgo().
Mon, Sep 2, 9:58 PM
johanneszarl committed R463:6caf462e21e7: Refactor DescriptionUtils: use namespaces and proper names. (authored by johanneszarl).
Refactor DescriptionUtils: use namespaces and proper names.
Mon, Sep 2, 9:58 PM
johanneszarl committed R463:19fb08e488d8: Fix i18n calls. (authored by johanneszarl).
Fix i18n calls.
Mon, Sep 2, 9:58 PM

Aug 23 2019

johanneszarl committed R463:d884423f3885: .clang-format: document problems with clang-format 6.0.0 (authored by johanneszarl).
.clang-format: document problems with clang-format 6.0.0
Aug 23 2019, 10:26 PM

Aug 21 2019

johanneszarl added a comment to T11214: Running clang-format across all plasma (and potentially over repos).

One other thing that we ran into in KPhotoAlbum is that apparently clang-format is not entirely stable in its results. I got slightly different results between 6.0.0, 7.0.1, and 7.1.0.
So when you create your .clang-format file you should do some testing to get consistent results across all developers.

Aug 21 2019, 10:05 PM

Aug 16 2019

johanneszarl closed T11409: Website: Update text and screenshots for the three minute tour as Invalid.

This issue is already being dealt with in T11335...

Aug 16 2019, 8:31 PM · KPhotoAlbum

Aug 15 2019

johanneszarl committed R463:0c244d0cabfd: Make it possible to skip clang-format commit hook. (authored by johanneszarl).
Make it possible to skip clang-format commit hook.
Aug 15 2019, 9:23 PM
johanneszarl added a comment to T11335: Update kphotoalbum website.

I've improved the texts a bit (see merge request), removing some paragraphs as I saw fit.

Aug 15 2019, 8:55 PM · Junior Jobs, KPhotoAlbum, Websites
johanneszarl committed R463:99ff18b2ba1b: Add guard-blocks for clang-format. (authored by johanneszarl).
Add guard-blocks for clang-format.
Aug 15 2019, 8:04 PM
johanneszarl committed R463:74d3f1d252cc: Fix compiler warning for ImageInfo copy ctor. (authored by johanneszarl).
Fix compiler warning for ImageInfo copy ctor.
Aug 15 2019, 7:50 PM

Aug 14 2019

johanneszarl created T11409: Website: Update text and screenshots for the three minute tour.
Aug 14 2019, 10:08 PM · KPhotoAlbum
johanneszarl added a comment to T11335: Update kphotoalbum website.

@simonkr Yes, deleting it is ok from my point of view.

Aug 14 2019, 10:04 PM · Junior Jobs, KPhotoAlbum, Websites

Aug 13 2019

johanneszarl added a comment to T11335: Update kphotoalbum website.

Do we need also the Videos page?: https://www.kphotoalbum.org/documentation/videos/ Because the Videos looks a bit Out of date.

Aug 13 2019, 8:38 PM · Junior Jobs, KPhotoAlbum, Websites

Jul 31 2019

johanneszarl committed R463:0a431ebf2967: Try fixing doxygen rendering on api.kde.org. (authored by johanneszarl).
Try fixing doxygen rendering on api.kde.org.
Jul 31 2019, 9:42 PM
johanneszarl committed R463:f593c2b8f5af: Fix typo in documentation. (authored by johanneszarl).
Fix typo in documentation.
Jul 31 2019, 9:42 PM
johanneszarl committed R463:94ed1297dce4: Apidoc. (authored by johanneszarl).
Apidoc.
Jul 31 2019, 8:08 PM

Jul 28 2019

johanneszarl committed R463:b4dee06d80de: Update changelog. (authored by johanneszarl).
Update changelog.
Jul 28 2019, 12:53 AM
johanneszarl committed R463:d1381b05a822: Make it possible to hide toolbars. (authored by johanneszarl).
Make it possible to hide toolbars.
Jul 28 2019, 12:53 AM

Jul 27 2019

johanneszarl added a comment to T11214: Running clang-format across all plasma (and potentially over repos).

At kphotoalbum, we just enabled clang-format for the code-base. So far, my experience was mostly boring (the good kind of boring).

Jul 27 2019, 7:31 PM
johanneszarl committed R463:a565ab1df4ef: Run clang-format on main.cpp (authored by johanneszarl).
Run clang-format on main.cpp
Jul 27 2019, 7:22 PM
johanneszarl committed R463:0d0949c6c117: Tweak .clang-format (authored by johanneszarl).
Tweak .clang-format
Jul 27 2019, 7:22 PM
johanneszarl committed R463:e7bad0297dcc: FilterWidget: actually persist user-set shortcuts. (authored by johanneszarl).
FilterWidget: actually persist user-set shortcuts.
Jul 27 2019, 12:01 AM
johanneszarl committed R463:3c48fe15f472: FilterWidget: don't display keyboard shortcuts. (authored by johanneszarl).
FilterWidget: don't display keyboard shortcuts.
Jul 27 2019, 12:01 AM
johanneszarl committed R463:498afd981dbb: FilterWidget: make toggle action available as shortcut. (authored by johanneszarl).
FilterWidget: make toggle action available as shortcut.
Jul 27 2019, 12:01 AM

Jul 26 2019

johanneszarl committed R463:3f563f67cbb9: Use correct i18n* function. (authored by johanneszarl).
Use correct i18n* function.
Jul 26 2019, 9:08 PM
johanneszarl committed R463:6149ce25dcc9: Fix QActions without text runtime warning. (authored by johanneszarl).
Fix QActions without text runtime warning.
Jul 26 2019, 9:08 PM
johanneszarl committed R463:b806d322f30b: FilterWidget: allow keyboard shortcuts to toggle rating. (authored by johanneszarl).
FilterWidget: allow keyboard shortcuts to toggle rating.
Jul 26 2019, 9:08 PM
johanneszarl committed R463:ddcf078c6657: Merge branch 'feature/thumbnailFilterShortcuts' (authored by johanneszarl).
Merge branch 'feature/thumbnailFilterShortcuts'
Jul 26 2019, 8:40 PM
johanneszarl committed R463:c0dad572a87c: Refactor FilterWidget facade. (authored by johanneszarl).
Refactor FilterWidget facade.
Jul 26 2019, 8:40 PM
johanneszarl committed R463:e705d535267b: Fix hover-effect for TaggedArea in Viewer. (authored by johanneszarl).
Fix hover-effect for TaggedArea in Viewer.
Jul 26 2019, 7:53 PM
johanneszarl committed R463:54976143409e: Properly document a workaround. (authored by johanneszarl).
Properly document a workaround.
Jul 26 2019, 5:51 PM

Jul 25 2019

johanneszarl committed R463:4d8c571821a1: Add shortcuts for rating filter in ThumbnailView (authored by johanneszarl).
Add shortcuts for rating filter in ThumbnailView
Jul 25 2019, 9:29 PM
johanneszarl committed R463:b976afa61acc: Api doc (authored by johanneszarl).
Api doc
Jul 25 2019, 9:16 PM

Jul 22 2019

johanneszarl committed R463:3e0ed8a222dc: Fix compilation after rebase. (authored by johanneszarl).
Fix compilation after rebase.
Jul 22 2019, 10:40 PM
johanneszarl committed R463:d12fbe893866: Add check to determine Marble version. (authored by johanneszarl).
Add check to determine Marble version.
Jul 22 2019, 10:40 PM
johanneszarl committed R463:486a4418cd8e: Quick half-way hack to make updateRegionSelection work with older Marble. (authored by johanneszarl).
Quick half-way hack to make updateRegionSelection work with older Marble.
Jul 22 2019, 10:40 PM
johanneszarl committed R463:a1bee1f55b16: Re-added region selection (authored by tleupold).
Re-added region selection
Jul 22 2019, 10:40 PM
johanneszarl committed R463:3699eff48d2c: Added markers and thumbnails to the map (authored by tleupold).
Added markers and thumbnails to the map
Jul 22 2019, 10:40 PM
johanneszarl committed R463:0f17ad752c12: Cleanup (authored by tleupold).
Cleanup
Jul 22 2019, 10:40 PM
johanneszarl committed R463:cad0c8d9b4c4: Implemented MapView::zoomToMarkers() (authored by tleupold).
Implemented MapView::zoomToMarkers()
Jul 22 2019, 10:40 PM
johanneszarl committed R463:30fbe689204e: Fix conversion to Marble::GeoDataCoordinates (authored by johanneszarl).
Fix conversion to Marble::GeoDataCoordinates
Jul 22 2019, 10:40 PM
johanneszarl committed R463:a02b621491d1: Finally fix layer name (authored by johanneszarl).
Finally fix layer name
Jul 22 2019, 10:40 PM
johanneszarl committed R463:f74563cbb713: Add operator QString() to geocoordinates. (authored by johanneszarl).
Add operator QString() to geocoordinates.
Jul 22 2019, 10:40 PM
johanneszarl committed R463:815cc289b559: Fix layer name for Marble LayerInterface (authored by johanneszarl).
Fix layer name for Marble LayerInterface
Jul 22 2019, 10:40 PM
johanneszarl committed R463:ab6f12e7a421: Remove Map/MarkerLayer (authored by johanneszarl).
Remove Map/MarkerLayer
Jul 22 2019, 10:40 PM
johanneszarl committed R463:6ebee888eaf0: Integrate LayerInterface with MapView. (authored by johanneszarl).
Integrate LayerInterface with MapView.
Jul 22 2019, 10:40 PM
johanneszarl committed R463:36dc29f12044: Always use addImage(ImageInfoPtr) for MapView. (authored by johanneszarl).
Always use addImage(ImageInfoPtr) for MapView.
Jul 22 2019, 10:40 PM
johanneszarl committed R463:e2769a5a5c9c: Reimplemented two times setCenter() and setLastCenter() (authored by tleupold).
Reimplemented two times setCenter() and setLastCenter()
Jul 22 2019, 10:40 PM
johanneszarl committed R463:08aeef7d0d11: WIP: Trying to add markers (authored by tleupold).
WIP: Trying to add markers
Jul 22 2019, 10:40 PM
johanneszarl committed R463:0d433e9e34d8: MapView: Save and restore floaters visibility (authored by tleupold).
MapView: Save and restore floaters visibility
Jul 22 2019, 10:40 PM
johanneszarl committed R463:284ae5e8761c: MapWidget: Add view/hide buttons for all floating items (authored by tleupold).
MapWidget: Add view/hide buttons for all floating items
Jul 22 2019, 10:40 PM
johanneszarl committed R463:d9fc988de439: Removed libkgeomap. (authored by tleupold).
Removed libkgeomap.
Jul 22 2019, 10:40 PM
johanneszarl committed R463:6ea908034443: Addded a wrapper class to eventually remove all KGeoMap::GeoCoordinates. (authored by tleupold).
Addded a wrapper class to eventually remove all KGeoMap::GeoCoordinates.
Jul 22 2019, 10:40 PM
johanneszarl committed R463:b420073d8634: Add launchable tag to appdata.xml (authored by johanneszarl).
Add launchable tag to appdata.xml
Jul 22 2019, 10:40 PM
johanneszarl committed R463:a62cfbdeec2c: Added some buttons to toggel floating items. (authored by tleupold).
Added some buttons to toggel floating items.
Jul 22 2019, 10:40 PM
johanneszarl committed R463:ebc752bbbd38: Removed the libkgeomap dependency (authored by tleupold).
Removed the libkgeomap dependency
Jul 22 2019, 10:40 PM
johanneszarl committed R463:e9ebc66cba1a: Added a Marble map to Map::MapView. (authored by tleupold).
Added a Marble map to Map::MapView.
Jul 22 2019, 10:40 PM
johanneszarl committed R463:ef8f925e0929: Removed libkgeomap. (authored by tleupold).
Removed libkgeomap.
Jul 22 2019, 10:40 PM
johanneszarl committed R463:e0443d7a1889: Removed the MapMarkerModelHelper and SearchMarkerTiler helper classes. (authored by tleupold).
Removed the MapMarkerModelHelper and SearchMarkerTiler helper classes.
Jul 22 2019, 10:40 PM
johanneszarl committed R463:71d2aeee4c58: Removed libkgeomap from Map::GeoCoordinates. (authored by tleupold).
Removed libkgeomap from Map::GeoCoordinates.
Jul 22 2019, 10:40 PM
johanneszarl committed R463:42033229cba1: Removed the direct usage of KGeoMap::GeoCoordinates. (authored by tleupold).
Removed the direct usage of KGeoMap::GeoCoordinates.
Jul 22 2019, 10:40 PM
johanneszarl committed R463:201931b20b2d: WIP: Remove libkgeomap dependencies from Map::GeoCoordinates. (authored by tleupold).
WIP: Remove libkgeomap dependencies from Map::GeoCoordinates.
Jul 22 2019, 10:40 PM
johanneszarl committed R463:3b7a930ba6b2: Addded a wrapper class to eventually remove all KGeoMap::GeoCoordinates. (authored by tleupold).
Addded a wrapper class to eventually remove all KGeoMap::GeoCoordinates.
Jul 22 2019, 10:40 PM

Jul 21 2019

johanneszarl closed T11165: Merge branch dev-improvements as Resolved.

The changes have all been implemented.

Jul 21 2019, 10:11 PM · KPhotoAlbum
johanneszarl committed R463:ab41accbef5e: Document code formatting rules. (authored by johanneszarl).
Document code formatting rules.
Jul 21 2019, 10:10 PM