Update konsole website
ClosedPublic

Authored by ognarb on Apr 20 2019, 7:46 PM.

Details

Summary

Use new theme similar to kde.org, kontact.kde.org, ...

Still need some better description.

Test Plan

A test demo is available at http://irl.carlschwan.eu/

Diff Detail

Repository
R935 Konsole Website
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 12170
Build 12188: arc lint + arc unit
ognarb created this revision.Apr 20 2019, 7:46 PM
Restricted Application added a project: Konsole. · View Herald TranscriptApr 20 2019, 7:46 PM
Restricted Application added a subscriber: konsole-devel. · View Herald Transcript
ognarb requested review of this revision.Apr 20 2019, 7:46 PM
ognarb edited the test plan for this revision. (Show Details)Apr 20 2019, 8:31 PM

Will leave the content for @hindenburg to review.

As you are switching to Jekyll it is imperative that you do not merge this until Sysadmin has changed the setup on the server and provisioned generation of the site, otherwise you'll end up with a directory of bare *.md files.

ognarb edited the test plan for this revision. (Show Details)Apr 20 2019, 9:07 PM

Will leave the content for @hindenburg to review.

As you are switching to Jekyll it is imperative that you do not merge this until Sysadmin has changed the setup on the server and provisioned generation of the site, otherwise you'll end up with a directory of bare *.md files.

Don't worry this wasn't my plan ;)

ognarb updated this revision to Diff 56640.Apr 20 2019, 10:04 PM

Use collection to store changelogs

ognarb updated this revision to Diff 56641.Apr 20 2019, 10:18 PM

Link to individual changelogs

ognarb updated this revision to Diff 56642.Apr 20 2019, 10:25 PM

Fix typos

ognarb updated this revision to Diff 56680.Apr 21 2019, 7:57 PM

Add screenshots

Just my 2 cents : I would rename "for users" to something more obvious like User support or something better and have the Get Involved bellow (before Donate). The reason for the last item is that I think that this websites target is more potentiel users than contributors.

The same should apply to Kontact.

Be careful, the title on your website is still Kontact suite

Would there be a way to have two repos?

One with the mechanics that all websites would use and one with the simple content and pictures of the given website? This would prevent websites to diverge and help keeping the up to date and all looking alike

ognarb updated this revision to Diff 56687.Apr 21 2019, 10:09 PM

Upload full changelog

ognarb updated this revision to Diff 56688.Apr 21 2019, 10:13 PM

Change _config.yml. Thanks @ochurlaud

ognarb updated this revision to Diff 56689.Apr 21 2019, 10:20 PM

Change page order in nav and rename For Users to User support

ognarb added a comment.EditedApr 21 2019, 10:28 PM

Would there be a way to have two repos?

One with the mechanics that all websites would use and one with the simple content and pictures of the given website? This would prevent websites to diverge and help keeping the up to date and all looking alike

It might make sense, to have one shared repository for the stylesheet/javascript (cdn.kde.org) only. But otherwise the code for kontact.kde.org and konsole.kde.org differs a lot (_include/head.html, _include/footer.html, _layouts/default.html and _layout/page.html are the only similar file across the two repos).

ognarb updated this revision to Diff 56690.Apr 21 2019, 10:59 PM

Add full changelog with 19.04

ognarb updated this revision to Diff 56742.Apr 22 2019, 1:31 PM

Improve index

Would there be a way to have two repos?

One with the mechanics that all websites would use and one with the simple content and pictures of the given website? This would prevent websites to diverge and help keeping the up to date and all looking alike

I started creating a Jekyll theme: https://invent.kde.org/carlschwan/kde-jekyll-theme. For the moment, I only tested with a simplified version of the Konsole website. But there are still some issues: https://invent.kde.org/carlschwan/kde-jekyll-theme/issues.

Are we waiting on the sysadmins? And if so, does anyone know the timeline? BTW, thanks for working on this.

As mentioned in my earlier comment, it is waiting on your approval for content Kurt.

Once you've okayed it, we'll need a ticket to arrange for the switchover to Jekyll based generation.

How did I miss this!?!?! It looks amazing! if you're good with the content, @hindenburg, can you formally approve so the Sysadmins can do the necessary work on their side? Thanks!

GB_2 added a subscriber: GB_2.May 25 2019, 7:19 AM

The main header with the wallpaper and title doesn't exactly look like on kontact.kde.org, it also misses some top padding. Other than that it looks great!

hindenburg accepted this revision.May 25 2019, 9:57 AM

Thanks, any minor changes can be done afterwards.

This revision is now accepted and ready to land.May 25 2019, 9:57 AM
ognarb updated this revision to Diff 58631.May 25 2019, 11:18 AM

Move boilerplate code to another repository (https://invent.kde.org/carlschwan/kde-jekyll-theme)

A syadmin request was created to move this repo to KDE infrastructure. T10981

ognarb added a comment.EditedMay 25 2019, 11:38 AM
In D20701#469700, @GB_2 wrote:

The main header with the wallpaper and title doesn't exactly look like on kontact.kde.org, it also misses some top padding. Other than that it looks great!

Yes I saw that, the problem is that kontact.kde.org doesn't include this css file with all the typography: https://kde.org/css/aetherCore.css. I will create a patch for kontact.kde.org.

What top padding do you mean?

Kurt, could you please create a branch in the Konsole website repository containing this work?
I'll then be able to arrange the switchover.

Kurt, could you please create a branch in the Konsole website repository containing this work?
I'll then be able to arrange the switchover.

Could you please check that I have permission to add a branch? I might have something wrong on my end.

Push  URL: git@git.kde.org:websites/konsole-kde-org

FATAL: W any websites/konsole-kde-org hindenburg DENIED by fallthru

Sorry, you didn't have any access to websites/konsole-kde-org, i've now sorted that out.

Sysadmin task created: T10996

ognarb updated this revision to Diff 58799.May 28 2019, 5:01 PM

Fix layout and remove todo get-involved

@hindenburg Sysadmin did the setup, you need now to push the change to make it live 🎉.

@hindenburg Sysadmin did the setup, you need now to push the change to make it live 🎉.

I can't view that task - do you know if I can commit to master or does Ben still want a branch?

Master is fine in this instance. If the system fails to build the site for whatever reason, the current version of the website will stay up.

hindenburg closed this revision.May 31 2019, 1:50 AM

Thanks to everyone who helped on this. I manually committed this as I couldn't get arc to work correctly.

https://cgit.kde.org/websites/konsole-kde-org.git/commit/?id=20b7949a671e83f5f8126dce2285f39c3db0dbf1

Hmm, https://konsole.kde.org is still showing the old content for me.

Hmm, https://konsole.kde.org is still showing the old content for me.

@bcooksley is there a way to see the ci log, so that I can see that went wrong?

Please see https://binary-factory.kde.org/view/Websites/job/Website_konsole-kde-org/

Please note that pulling in external Gems on demand as part of website builds is not supported within this environment, although they can be pre-installed.

Please see https://binary-factory.kde.org/view/Websites/job/Website_konsole-kde-org/

Please note that pulling in external Gems on demand as part of website builds is not supported within this environment, although they can be pre-installed.

Ok, can we pre-install https://anongit.kde.org/websites/jekyll-kde-theme.git ;)

Sorry, i'm not a massive user of gems/etc - you'll need to provide more detailed instructions or a patch to https://invent.kde.org/sysadmin/ci-tooling/blob/master/system-images/static-websites/Dockerfile

Sorry, i'm not a massive user of gems/etc - you'll need to provide more detailed instructions or a patch to https://invent.kde.org/sysadmin/ci-tooling/blob/master/system-images/static-websites/Dockerfile

No problems, I will submit a patch ;)

Alas, something about the Konsole website config makes it unhappy still - https://binary-factory.kde.org/view/Websites/job/Website_konsole-kde-org/3/console

ognarb added a comment.Jun 3 2019, 7:26 AM

Alas, something about the Konsole website config makes it unhappy still - https://binary-factory.kde.org/view/Websites/job/Website_konsole-kde-org/3/console

I submitted a new patch: https://invent.kde.org/sysadmin/ci-tooling/merge_requests/11/ Hopeful it works this time.

Looks like this commit was badly applied.
The directory structure is broken here https://cgit.kde.org/websites/konsole-kde-org.git/tree/ (all the directory are missing and the content was moved to the root directory) and some files are missing (e.g assets/img/Next.jpg). I created a new patch D20701 to fix it.