[KNotification] Add HighUrgency
ClosedPublic

Authored by broulik on Apr 18 2019, 8:14 AM.

Details

Summary

Freedesktop notifications only know low, normal, critical, whereas both xdg notification portal and Android have more fine-grained priority levels.
Also, space the enum values apart so we can add new ones later easily, if neccessary.

Diff Detail

Repository
R289 KNotifications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Apr 18 2019, 8:14 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 18 2019, 8:14 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
broulik requested review of this revision.Apr 18 2019, 8:14 AM
vkrause accepted this revision.Apr 18 2019, 8:17 AM

Thanks!

This revision is now accepted and ready to land.Apr 18 2019, 8:17 AM
dfaure added inline comments.Apr 18 2019, 8:37 AM
src/knotification.h
283 ↗(On Diff #56493)

Isn't the change of value BIC?

broulik added inline comments.Apr 18 2019, 8:38 AM
src/knotification.h
283 ↗(On Diff #56493)

Even if it was, this stuff isn't released yet

Ah, great, thanks.

This revision was automatically updated to reflect the committed changes.