QSysInfo works on both unix like and windows OS's.
Better to use it to gather information about the system.
Details
Details
- Reviewers
dfaure - Commits
- R241:0d2681df45f8: Rely upon QSysInfo to retrieve the system details
Ran ctest, tests executed successfully
kcmshell5 --useragent
Diff Detail
Diff Detail
- Repository
- R241 KIO
- Branch
- sysinfo
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 11991 Build 12009: arc lint + arc unit
Comment Actions
I like the idea.
The commit template has a "Test Plan" field, but it seems it was left empty - can you detail what tests you did?
Comment Actions
Also, please explicitly mention what are the changes done. "refactor and cleanup" is very vague, while saying that, for example, QSysInfo is used on all the OSes is better.
Comment Actions
- The description still says "Refactor and cleanup" (note that phabricator doesn't auto-update from the commit log, unless you use arc diff --verbatim, so one often has to copy/paste)
- Running the unittests is always good, but they don't cover this code. Please actually use the KCM to test this commit. I would put some nonsense into appSysName first, to make sure I'm testing correctly, then putting back the right value, to make sure it's correct.
Comment Actions
Please make sure to edit the commit log -- the phabricator description still says "Refactor and cleanup" ...
This comment was removed by shubham.