Differential D20465

[KDynamicJobTracker] When kuiserver isn't available, also fall back to widget dialog
ClosedPublic
Actions

Authored by broulik on Apr 11 2019, 12:48 PM.

Details

Reviewers
dfaure
lbeltrame
Group Reviewers
Frameworks
Commits
R241:580fec7c0b20: [KDynamicJobTracker] When kuiserver isn't available, also fall back to widget…
Summary

It asks kuiserver whether we need to display a widget job tracker.
However, kuiserver itself might not be available at this point, so handle the call itself failing, too.

BUG: 379887

Test Plan

In preparation to kill kuiserver and move what it does into plasmashell

Killed plasmashell, got a dialog now that kuiserver dbus service didn't autostart anymore

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Apr 11 2019, 12:48 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 11 2019, 12:48 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
broulik requested review of this revision.Apr 11 2019, 12:48 PM
broulik added a comment.Apr 11 2019, 6:09 PM

I think so, it's the very same patch in that bugreport :) So, this patch makes even more sense, I only considered the Plasma case

ngraham edited the summary of this revision. (Show Details)Apr 11 2019, 6:13 PM
dfaure accepted this revision.Apr 12 2019, 7:13 AM
This revision is now accepted and ready to land.Apr 12 2019, 7:13 AM
Closed by commit R241:580fec7c0b20: [KDynamicJobTracker] When kuiserver isn't available, also fall back to widget… (authored by broulik). · Explain WhyApr 12 2019, 10:40 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/widgets/kdynamicjobtracker.cpp (5 lines)

Diff 56052

View Options

src/widgets/kdynamicjobtracker.cpp

Loading...