[Task Manager] Fix collapsing tooltip preview area for launchers
AbandonedPublic

Authored by broulik on Jun 29 2016, 4:54 PM.

Details

Reviewers
hein
bshah
Group Reviewers
Plasma
Summary

BUG: 364900
FIXED-IN: 5.7.0

Test Plan
  • Regular windows still have window thumbs
  • Groups have multiple window thumbs
  • Regular launchers have no thumbnail area whatsoever (compact tooltip)
  • Launchers of players still get album art

Diff Detail

Repository
R119 Plasma Desktop
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik updated this revision to Diff 4856.Jun 29 2016, 4:54 PM
broulik retitled this revision from to [Task Manager] Fix collapsing tooltip preview area for launchers.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added reviewers: Plasma, hein, bshah.
broulik set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma. · View Herald TranscriptJun 29 2016, 4:54 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
hein edited edge metadata.EditedJun 30 2016, 7:46 AM

My concern with this is that Plasma's tooltip appearance is currently very ugly: When you move between two bottom panel tooltips of different vertical size, as it resizes, the lower edge of the tooltip will "detach" from the panel. It looks like the tooltip "jumps" in a Flappy Bird-like manner. This looks so embarassingly shoddy and bad I consider it unshippable to end users. I think until we fix this, we should avoid making tooltips different heights at all costs.

mart added a subscriber: mart.Jun 30 2016, 9:12 AM

+1 for me for the patch

In D2045#37877, @hein wrote:

My concern with this is that Plasma's tooltip appearance is currently very ugly: When you move between two bottom panel tooltips of different vertical size, as it resizes, the lower edge of the tooltip will "detach" from the panel. It looks like the tooltip "jumps" in a Flappy Bird-like manner.

uhm, no? here the tooltip stays well attached to the panel edge during transition, i wouldn't want it to behave in any way different?

hein added a comment.Jun 30 2016, 9:46 AM

uhm, no? here the tooltip stays well attached to the panel edge during transition, i wouldn't want it to behave in any way different?

Not on my system: If I move the cursor from a window (tall tooltip) to a launcher (small tooltip), the lower tooltip edge detaches from the panel by 2-3mm and moves back down during animation. Looks goofy.

I recently did some changes to the text labels already to avoid most vertical size changes between tasks, because the tooltip hopping moving the cursor across the panel was so so bad.

mart added a comment.Jun 30 2016, 12:28 PM
In D2045#37891, @hein wrote:

Not on my system: If I move the cursor from a window (tall tooltip) to a launcher (small tooltip), the lower tooltip edge detaches from the panel by 2-3mm and moves back down during animation. Looks goofy.

can you do a screencast? is not supposed to do that
(here doesn't but maybe because it's low dpi?)

hein added a comment.Jun 30 2016, 12:47 PM

^ There you go

mart added a comment.Jul 1 2016, 8:48 AM
In D2045#37901, @hein wrote:

^ There you go

ewwww..
here doesn't do it at all :/ don't know how to reproduce
ùcan you make sure that you are using the proper "morphing popups" effect, not a locally modified version in ~/.local
and iirc there was also another version, probably on ghns floating around, that both may be enabled?

mart added a comment.Jul 1 2016, 8:57 AM

also, if this problem happens only for you, it still has to be found out why, but the patch should go forward

hein added a comment.Jul 1 2016, 9:12 AM

Morphing popups is enabled, and I never had any other version ...

broulik abandoned this revision.Jan 11 2017, 9:41 AM

Obsolete with new Plasma 5.9 design