Differential D20417

Add invokable public API for emitting contextualActionsAboutToShow
ClosedPublic
Actions

Authored by davidedmundson on Apr 9 2019, 9:16 PM.

Details

Reviewers
broulik
Group Reviewers
Plasma
Commits
R242:83d85dc2288c: Add invokable public API for emitting contextualActionsAboutToShow
Summary

This signal is emitted just before showing the context menu to allow
lazy-loading expensive actions like hasAlternatives.

This emitted by our code whenever we show a context menu from an event
filter, however we want to use this code from a tooltip in D17410

Test Plan

Hovered over some applets, they correctly enabled/disabled the
alternatives button

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Apr 9 2019, 9:16 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 9 2019, 9:16 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
davidedmundson requested review of this revision.Apr 9 2019, 9:16 PM
broulik accepted this revision.Apr 10 2019, 6:12 PM
broulik added a subscriber: broulik.

Thanks for taking care of this

This revision is now accepted and ready to land.Apr 10 2019, 6:12 PM
GB_2 added a subscriber: GB_2.Apr 10 2019, 6:18 PM

Yeah, thanks a lot!

Closed by commit R242:83d85dc2288c: Add invokable public API for emitting contextualActionsAboutToShow (authored by davidedmundson). · Explain WhyApr 12 2019, 2:47 PM
This revision was automatically updated to reflect the committed changes.

Showing Only Differences

This revision modifies 2 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

Path
No data available.

Diff 56072