true, but then the instance is there anyway. what we gain from this?

In D20335#446223, @tcanabrava wrote:

true, but then the instance is there anyway. what we gain from this?

we remove compiler warning

In D20335#446381, @andreagenor wrote:

In D20335#446223, @tcanabrava wrote:

true, but then the instance is there anyway. what we gain from this?

we remove compiler warning

Which warning exactly? I do not see any when building kolourpaint/master on my own machine.

I believe that he builds in clang and clang 8 added quite a bunch of new
warnings

Em ter, 9 de abr de 2019 às 06:55, Pino Toscano <noreply@phabricator.kde.org>
escreveu:

pino added a comment. View Revision https://phabricator.kde.org/D20335

In D20335#446381 https://phabricator.kde.org/D20335#446381, @andreagenor
https://phabricator.kde.org/p/andreagenor/ wrote:

In D20335#446223 https://phabricator.kde.org/D20335#446223, @tcanabrava
https://phabricator.kde.org/p/tcanabrava/ wrote:

true, but then the instance is there anyway. what we gain from this?

we remove compiler warning

Which warning exactly? I do not see any when building kolourpaint/master
on my own machine.

*REPOSITORY*
R374 KolourPaint

*REVISION DETAIL*
https://phabricator.kde.org/D20335

*To: *andreagenor, tcanabrava
*Cc: *pino

This is the warning I get
https://clang.llvm.org/extra/clang-tidy/checks/readability-static-accessed-through-instance.html