Remove warning static member accessed through instance
ClosedPublic

Authored by andreagenor on Apr 7 2019, 6:09 AM.

Details

Summary

Signed-off-by: André Agenor <andreagenor@icloud.com>
The QApplication static member doesn't need to be accessed through an instance

Diff Detail

Repository
R374 KolourPaint
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
andreagenor requested review of this revision.Apr 7 2019, 6:09 AM
andreagenor created this revision.

true, but then the instance is there anyway. what we gain from this?

true, but then the instance is there anyway. what we gain from this?

we remove compiler warning

pino added a subscriber: pino.Apr 9 2019, 4:55 AM

true, but then the instance is there anyway. what we gain from this?

we remove compiler warning

Which warning exactly? I do not see any when building kolourpaint/master on my own machine.

I believe that he builds in clang and clang 8 added quite a bunch of new
warnings

Em ter, 9 de abr de 2019 às 06:55, Pino Toscano <noreply@phabricator.kde.org>
escreveu:

pino added a comment. View Revision https://phabricator.kde.org/D20335

In D20335#446381 https://phabricator.kde.org/D20335#446381, @andreagenor
https://phabricator.kde.org/p/andreagenor/ wrote:

In D20335#446223 https://phabricator.kde.org/D20335#446223, @tcanabrava
https://phabricator.kde.org/p/tcanabrava/ wrote:

true, but then the instance is there anyway. what we gain from this?

we remove compiler warning

Which warning exactly? I do not see any when building kolourpaint/master
on my own machine.

*REPOSITORY*
R374 KolourPaint

*REVISION DETAIL*
https://phabricator.kde.org/D20335

*To: *andreagenor, tcanabrava
*Cc: *pino

tcanabrava accepted this revision.Mon, May 6, 12:21 PM
This revision is now accepted and ready to land.Mon, May 6, 12:21 PM
This revision was automatically updated to reflect the committed changes.