Differential D20324

Fix build with exiv2 0.28
ClosedPublic
Actions

Authored by nicolasfella on Apr 6 2019, 9:26 PM.

Details

Reviewers
mgallien
astippich
bruns
Commits
R286:50d14ea058b5: Fix build with exiv2 0.28
Summary

Exiv2::Image::AutoPtr has been replaced with Exiv2::Image::UniqePtr in current master

Test Plan

exivextractor test passes, test images are indexed by Baloo

Diff Detail

Repository
R286 KFileMetaData
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.Apr 6 2019, 9:26 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptApr 6 2019, 9:26 PM
Restricted Application added subscribers: Baloo, kde-frameworks-devel. · View Herald Transcript
nicolasfella requested review of this revision.Apr 6 2019, 9:26 PM
nicolasfella edited the summary of this revision. (Show Details)Apr 6 2019, 9:28 PM
nicolasfella edited the test plan for this revision. (Show Details)
nicolasfella added reviewers: mgallien, astippich, bruns.
nicolasfella edited the summary of this revision. (Show Details)Apr 6 2019, 9:43 PM
bruns added inline comments.Apr 6 2019, 9:51 PM
src/extractors/exiv2extractor.cpp
152

Why not just #if EXIV2_TEST_VERSION(0,28,0) ?

nicolasfella updated this revision to Diff 55610.Apr 6 2019, 10:21 PM
  • Use EXIV_TEST_VERSION
nicolasfella added inline comments.Apr 6 2019, 10:22 PM
src/extractors/exiv2extractor.cpp
152

That makes an awful lot of sense

bruns accepted this revision.Apr 6 2019, 10:22 PM
This revision is now accepted and ready to land.Apr 6 2019, 10:22 PM
Closed by commit R286:50d14ea058b5: Fix build with exiv2 0.28 (authored by nicolasfella). · Explain WhyApr 6 2019, 10:25 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/extractors/exiv2extractor.cpp (4 lines)

Diff 55611

View Options

src/extractors/exiv2extractor.cpp

Loading...