Differential D20316

[MTimeDB] Fix lookup when time range should return empty set
ClosedPublic
Actions

Authored by bruns on Apr 6 2019, 6:53 PM.

Details

Reviewers
dfaure
ngraham
poboiko
astippich
Group Reviewers
Baloo
Frameworks
Commits
R293:fe7c3f13ecac: [MTimeDB] Fix lookup when time range should return empty set
Summary

MDB_RANGE_SET sets the cursor to the first element greater or equal the
key value. This element may be later than endTime and thus should not
be added to the result.

Reorder endTime check and appending the value, so only matching items
are returned. If the result set is empty, directly return.

Test Plan

ctest

Diff Detail

Repository
R293 Baloo
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bruns created this revision.Apr 6 2019, 6:53 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptApr 6 2019, 6:53 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
bruns requested review of this revision.Apr 6 2019, 6:53 PM
ngraham accepted this revision.Apr 6 2019, 10:52 PM
This revision is now accepted and ready to land.Apr 6 2019, 10:52 PM
Closed by commit R293:fe7c3f13ecac: [MTimeDB] Fix lookup when time range should return empty set (authored by bruns). · Explain WhyApr 6 2019, 11:08 PM
This revision was automatically updated to reflect the committed changes.

Showing Only Differences

This revision modifies 3 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

Path
No data available.

Diff 55613