Differential D20196

Add Notify capability to KConfigXT
ClosedPublic
Actions

Authored by broulik on Apr 2 2019, 8:16 AM.

Details

Reviewers
dfaure
davidedmundson
Group Reviewers
Frameworks
Commits
R237:5d2ed13479a4: Add Notify capability to KConfigXT
Summary

Lets you specify Notifiers= in .kcfg for config entries that should be written with Notify flag, i.e. announce the change to KConfigWatcher

Test Plan
  • Generated a kconfigxt with Notifiers=true, called a setter, had it notify others on dbus. New notification settings stuff heavily relies on it and works beautifully.

Diff Detail

Repository
R237 KConfig
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Apr 2 2019, 8:16 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 2 2019, 8:16 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
broulik requested review of this revision.Apr 2 2019, 8:16 AM
broulik edited the test plan for this revision. (Show Details)
davidedmundson added inline comments.Apr 2 2019, 9:39 AM
src/core/kcoreconfigskeleton.h
217 ↗(On Diff #55257)

Can you move the new flag into KConfigSkeletonItem which is d-pointered and expose write flags with a protected accessor?

broulik planned changes to this revision.Apr 5 2019, 2:12 PM
broulik updated this revision to Diff 55730.Apr 8 2019, 9:42 AM
broulik retitled this revision from RFC: Add Notify capability to KConfigXT to Add Notify capability to KConfigXT.
broulik edited the test plan for this revision. (Show Details)
  • Move stuff into KConfigSkeletonItem
davidedmundson accepted this revision.Apr 23 2019, 11:10 AM
This revision is now accepted and ready to land.Apr 23 2019, 11:10 AM
Closed by commit R237:5d2ed13479a4: Add Notify capability to KConfigXT (authored by broulik). · Explain WhyApr 24 2019, 2:21 PM
This revision was automatically updated to reflect the committed changes.

Showing Only Differences

This revision modifies 8 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

Diff 55730

View Options

src/core/kcoreconfigskeleton.h

Loading...
View Options

src/core/kcoreconfigskeleton.cpp

Loading...
View Options

src/core/kcoreconfigskeleton_p.h

Loading...