Add Notify capability to KConfigXT
ClosedPublic
Actions

Authored by broulik on Apr 2 2019, 8:16 AM.

Details

Reviewers

dfaure
davidedmundson

Group Reviewers

Frameworks

Commits

R237:5d2ed13479a4: Add Notify capability to KConfigXT

Summary

Lets you specify Notifiers= in .kcfg for config entries that should be written with Notify flag, i.e. announce the change to KConfigWatcher

Test Plan

Generated a kconfigxt with Notifiers=true, called a setter, had it notify others on dbus. New notification settings stuff heavily relies on it and works beautifully.

Repository

R237 KConfig

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

broulik requested review of this revision.Apr 2 2019, 8:16 AM

broulik edited the test plan for this revision. (Show Details)

src/core/kcoreconfigskeleton.h
231	Can you move the new flag into KConfigSkeletonItem which is d-pointered and expose write flags with a protected accessor?

broulik planned changes to this revision.Apr 5 2019, 2:12 PM

Ping

This revision is now accepted and ready to land.Apr 23 2019, 11:10 AM

This revision was automatically updated to reflect the committed changes.

		Path
M		autotests/kconfig_compiler/CMakeLists.txt (9 lines)
M		autotests/kconfig_compiler/kconfigcompiler_test.cpp (1 line)
A	M	autotests/kconfig_compiler/test_notifiers.h.ref (94 lines)
A	M	autotests/kconfig_compiler/test_notifiers.cpp.ref (34 lines)
A	M	autotests/kconfig_compiler/test_notifiers.kcfg (25 lines)
A	M	autotests/kconfig_compiler/test_notifiers.kcfgc (8 lines)
A	M	autotests/kconfig_compiler/test_notifiers_main.cpp (32 lines)
M		src/core/kcoreconfigskeleton.h (18 lines)
M		src/core/kcoreconfigskeleton.cpp (36 lines)
M		src/core/kcoreconfigskeleton_p.h (2 lines)
M		src/kconfig_compiler/kconfig_compiler.cpp (8 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	55257			Apr 2 2019, 8:12 AM	★	★
Diff 2	55730			Apr 8 2019, 9:41 AM	★	★
Diff 3	56898	b327f5f	R237:5d2ed13479a480111355657bf22324118fa576e9	Apr 24 2019, 2:21 PM	★	★

Status	Author	Revision
Closed	broulik	D20490 Rewrite notifications dataengine to work with libnotificationmanager
Closed	broulik	D20491 Rewrite applicationjobs dataengine to work with libnotificationmanager
Closed	broulik	D20576 Add new notifications KCM
Closed	broulik	D20266 Add new notification plasmoid
Closed	broulik	D21061 [Task Manager] Use libnotificationmanager for notification badges and application job reporting
Closed	broulik	D20265 Introduce libnotificationmanager
Closed	broulik	D20196 Add Notify capability to KConfigXT