make start-here-kde also available start-here-kde-plasma
ClosedPublic

Authored by sitter on Apr 1 2019, 4:27 PM.

Details

Summary

the latter offers a less ambiguous name when we want to refer to something
plasma specific. a recent example is D20172 which defines the icon for
something related to the Plasma workspace, as such the start-here-kde icon
may not be the most appropriate across all icon themes (i.e. if the icon
is in fact the KDE logo it's not what we want). conversely an icon theme
cannot offer a real start-here-kde since we use it in place of a plasma
variant.

with the additional name we'd be free to use less ambiguous icon references
in the future.
also, because of how icon naming works themes that provide start-here-kde
but not start-here-kde-plasma would still fall back to start-here-kde

Diff Detail

Repository
R266 Breeze Icons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sitter created this revision.Apr 1 2019, 4:27 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 1 2019, 4:27 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
sitter requested review of this revision.Apr 1 2019, 4:27 PM
broulik added a subscriber: broulik.Apr 1 2019, 4:41 PM

Imho when we did the rebranding we should have added a start-here-plasma icon and switch to that everywhere rather than blatantly changing the start-here-kde icon +1

ngraham accepted this revision.Apr 1 2019, 4:51 PM
This revision is now accepted and ready to land.Apr 1 2019, 4:51 PM
This revision was automatically updated to reflect the committed changes.