| ngraham | |
| astippich |
| Baloo | |
| Frameworks |
The ExtractorCollection::fetchExtractors method falls back to ancestor
mime types in case a type is not supported directly. For most extractors
this is no problem, as these ignore the passed in mime type and rely
on the backing library to figure out the type, while the taglibextractor
requires one of the supported (container) types.
For most cases the input type is returned, but it falls back to
inheritance, matching the logic from ExtractorCollection::fetchExtractors.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
| src/extractorplugin.h | ||
|---|---|---|
| 106 | Since when? :p | |
| src/extractorplugin.h | ||
|---|---|---|
| 106 | too early ;-) | |
Forget my comment, I thought it would be possible to share some code with the ExtractorCollection, but the implementation is too different
Oh, another idea: Cannot this be used to determine that the extractor supports the inheriting mimetype as required in D20121? Would need to be public for this, though, or the test needs to be made a friend class.
A friend declaration should work there. It should stay protected, as it is meant to be called by plugins only.