Use mime type helper to test ffmpeg extractor and add
new mime type
CCBUG: 399650
Details
Details
- Reviewers
bruns - Commits
- R286:25eca3185ffa: Test ffmpeg extractor using mime type helper
Diff Detail
Diff Detail
- Repository
- R286 KFileMetaData
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| src/extractors/ffmpegextractor.cpp | ||
|---|---|---|
| 64 ↗ | (On Diff #55059) | This is quite specific to the codec. ExtractorCollection should handle this case I think (mime type of file is more specific than in the mime type list), but I added it nevertheless. |
| autotests/ffmpegextractortest.cpp | ||
|---|---|---|
| 27 | remove comment | |
| src/extractors/ffmpegextractor.cpp | ||
| 64 ↗ | (On Diff #55059) | I am somewhat undecided on this one: The ffmpeg extractor leaves the handling of different types completely to libav (contrary to e.g. taglib, where each type is handled explicitly). So just defaulting to video/ogg already covers theora, and many more. I think it is better to test this in e.g. the extractorcollectiontest, and remove the QVERIFY for the mimetypes().contains(). |