Re-enable Move tab to left / right via keyboard shortcuts
Details
Details
- Reviewers
hindenburg - Group Reviewers
Konsole - Commits
- R319:c53e8cb17e11: Re enable move tab left / right via keyboard shortcuts
Diff Detail
Diff Detail
- Repository
- R319 Konsole
- Branch
- shortcutRework
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 10254 Build 10272: arc lint + arc unit
Comment Actions
Just tried this patch and it seems to work just fine for me.
| src/ViewManager.cpp | ||
|---|---|---|
| 206 | "Focus Right Terminal" would be more consistent | |
| 249 | restore-other-terminal should be something like "move-tab-right" | |
| 256 | Same here. Also if multiple actions have the same name you can only configure the last one in the shortcut config dialog. | |
Comment Actions
The QAction names need to stay the same if possible, otherwise previous shortcuts don't work. If they are changed, I'm not sure there's a way to automatically update them.
~/local/share/kxmlgui5/konsole/konsoleui.rc
<Action name="move-view-right" shortcut="Ctrl+Alt+["/> <Action name="restore-other-terminals" shortcut="Ctrl+Alt+]"/>
previous version
<Action shortcut="Ctrl+Alt+]" name="move-view-right"/> <Action shortcut="Ctrl+Alt+[" name="move-view-left"/>
Comment Actions
this should fix most of the issues. I have another patch to go related to actions, but this one needs to land first.
Comment Actions
The one issue I have, if you open just one tab and press the move left/right I get C for 'move right' and D for 'move left" echoed on the terminal. They go away when I open another terminal and don't appear to return even if I close all but one.
Don't worry too much about the minor nitpicks.
| src/ViewContainer.cpp | ||
|---|---|---|
| 578 ↗ | (On Diff #55037) | empty space at end - minor |
| 593 ↗ | (On Diff #55037) | minor nitpick that doesn't have to fix now - make sure there are newlines at end of files. |
Comment Actions
ON master w/o this patch, I still get the CD echoing on all the tabs when I try the shortcuts. So maybe it is something else. Is anyone else seeing this issue?
Comment Actions
Probably it's the fact that I'm enabling the tab shortcut only if there's more than one tab. when it's disabling, the shortcut will not go thru the action event, and thus will be send to the terminal emulator.
that's not relevant for this patch, though. then I ask you to accept this one and I'll look into the bug in master.
| src/ViewManager.cpp | ||
|---|---|---|
| 250 ↗ | (On Diff #55037) | For many years, moving tabs in konsole was done with Ctrl+Shift+Left/Right. |
| src/ViewManager.cpp | ||
|---|---|---|
| 250 ↗ | (On Diff #55037) | I didn't catch the change; Tomaz, was this a mistake? |
Comment Actions
I needed a new accelerator for focus split right left top bottom, I talked
to David this weekend and we agreed to restore the old accelerator for move
tab.
Em seg, 9 de set de 2019 às 16:06, Kurt Hindenburg <
noreply@phabricator.kde.org> escreveu:
hindenburg added inline comments. View Revision
https://phabricator.kde.org/D20115
*INLINE COMMENTS*
View Inline https://phabricator.kde.org/D20115#inline-134343dfaure
wrote in ViewManager.cpp:248For many years, moving tabs in konsole was done with Ctrl+Shift+Left/Right.
Any reason why this changed to Ctrl+Alt+Left/Right? I had to read the code
to find out why this was "broken"...I didn't catch the change; Tomaz, was this a mistake?
*REPOSITORY*
R319 Konsole*REVISION DETAIL*
https://phabricator.kde.org/D20115*To: *tcanabrava, Konsole, hindenburg
*Cc: *dfaure, mschiller, konsole-devel, fbampaloukas, thsurrel, ngraham,
maximilianocuria, hindenburg