Re-enable Move tab to left / right via keyboard shortcuts
- Group Reviewers
- R319:c53e8cb17e11: Re enable move tab left / right via keyboard shortcuts
Just tried this patch and it seems to work just fine for me.
"Focus Right Terminal" would be more consistent
restore-other-terminal should be something like "move-tab-right"
Same here. Also if multiple actions have the same name you can only configure the last one in the shortcut config dialog.
The QAction names need to stay the same if possible, otherwise previous shortcuts don't work. If they are changed, I'm not sure there's a way to automatically update them.
<Action name="move-view-right" shortcut="Ctrl+Alt+["/> <Action name="restore-other-terminals" shortcut="Ctrl+Alt+]"/>
<Action shortcut="Ctrl+Alt+]" name="move-view-right"/> <Action shortcut="Ctrl+Alt+[" name="move-view-left"/>
The one issue I have, if you open just one tab and press the move left/right I get C for 'move right' and D for 'move left" echoed on the terminal. They go away when I open another terminal and don't appear to return even if I close all but one.
Don't worry too much about the minor nitpicks.
empty space at end - minor
minor nitpick that doesn't have to fix now - make sure there are newlines at end of files.
Probably it's the fact that I'm enabling the tab shortcut only if there's more than one tab. when it's disabling, the shortcut will not go thru the action event, and thus will be send to the terminal emulator.
that's not relevant for this patch, though. then I ask you to accept this one and I'll look into the bug in master.