Some properties were missing proper number
localization
Details
Details
- Reviewers
bruns - Commits
- R286:607286e97229: Fix number localization for properties
Diff Detail
Diff Detail
- Repository
- R286 KFileMetaData
- Branch
- fix_value_localization
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 10203 Build 10221: arc lint + arc unit
| autotests/propertyinfotest.cpp | ||
|---|---|---|
| 97 ↗ | (On Diff #54650) | This will of course fail as soon as someone translates fps, e.g. german "B/s", even more in RTL locales. Probably the better solution is to provide the whole string verbatim, and mark it with i18n. Until then, tests should be run with an en or C locale. |
| autotests/propertyinfotest.cpp | ||
|---|---|---|
| 97 ↗ | (On Diff #54650) | I do not want to start adding translations to unit tests, that seems over the top. |
Comment Actions
Please drop the changes in the unit test.
| autotests/propertyinfotest.cpp | ||
|---|---|---|
| 97 ↗ | (On Diff #54650) | QLocale().toString() is insufficient, as a locale consists of many different settings, not all are captured in toString(), e.g. decimal grouping character and decimal point. Try running the tests with e.g. "LANG=ar ctest". It bails out at Property::Bitrate. |