Differential D19910

Hide the phonon widget when preview gets disabled
AbandonedPublic
Actions

Authored by meven on Mar 20 2019, 10:16 AM.

Details

Reviewers
elvisangelaccio
ngraham
Group Reviewers
Dolphin
Summary

Alternative to D19844 although it does not avoid to compute previews when they are disabled.

Test Plan
  1. In dolphin with an information panel with preview on
  2. launch the video preview
  3. Disable the preview

->bug: the video player control is still visible

Diff Detail

Repository
R318 Dolphin
Branch
fix-video-visibility
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 9895
Build 9913: arc lint + arc unit
meven created this revision.Mar 20 2019, 10:16 AM
Restricted Application added a project: Dolphin. · View Herald TranscriptMar 20 2019, 10:16 AM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
meven requested review of this revision.Mar 20 2019, 10:16 AM
meven edited the summary of this revision. (Show Details)Mar 20 2019, 10:20 AM
meven edited the test plan for this revision. (Show Details)
elvisangelaccio accepted this revision.Mar 20 2019, 9:15 PM

Haven't tried D19844 yet, but this patch can only make sense.

This revision is now accepted and ready to land.Mar 20 2019, 9:15 PM
meven abandoned this revision.Mar 24 2019, 5:40 PM

Fixed through D19844

Revision Contents
Changeset List

Diff 54401

View Options

src/panels/information/informationpanelcontent.cpp

Loading...