Add unique-window mode which opens uris in a new tab instead of a window

Authored by amhndu on Mar 19 2019, 1:41 PM.


Group Reviewers

Newly launched dolphin windows will close and the given files will be
opened in the previously opened window.

This can be overriden with the --new-window command line option and gives
flexibility to the user so that they can still create another window as they could

FEATURE: 183429

Test Plan

Go to Settings -> Startup and toggle the mode on.
Restart Dolphin and then try opening another instance.

Diff Detail

R318 Dolphin
No Linters Available
No Unit Test Coverage
Build Status
Buildable 9847
Build 9865: arc lint + arc unit
amhndu created this revision.Mar 19 2019, 1:41 PM
Restricted Application added a project: Dolphin. · View Herald TranscriptMar 19 2019, 1:41 PM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
amhndu requested review of this revision.Mar 19 2019, 1:41 PM

This is now the third patch we've received that implements this feature, the others being D16648 and D19150. I guess people really want it!

@elvisangelaccio, as maintainer, could you sort out our path forward here?

I was not aware there were patches that already did this.
I only found on the bug report which was abandoned, otherwise I would not have created another one!

No worries, the interest is appreciated anyway! I've updated the bug report so hopefully even more people don't fall into this situation. :) @elvisangelaccio will sort the patches out, and in the meantime, Dolphin has many other interesting projects that still need patches. Check out some of these:

Sorry for the delay. Let's focus on D16648 please, which has already started its review process.

amhndu abandoned this revision.Apr 12 2019, 4:57 AM

I understand