Bug symptom :
Fix the bugs and allow to avoid launching a PreviewJob with all files even when the preview is disabled.
Details
Details
- In dolphin with an information panel with preview on
- launch the video preview
- Disable the preview
->bug 1: the video player control is still visible (this bug fix this) - re-enable preview
-> bug 2: the video stays visible and the preview is displayed above (this bug fix this)
Diff Detail
Diff Detail
- Repository
- R318 Dolphin
- Branch
- arcpatch-D19844_2
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 10029 Build 10047: arc lint + arc unit
Comment Actions
Sorry to be pedantic, but we are fixing two different bugs, right? Would it be possible to split this patch into two commits?
Comment Actions
The two weird behavior are the same bug.
They sum up the same way : the video widget visibility is not synched to the state of the setting InformationPanelSettings::previewsShown.
Comment Actions
@ngraham I have made a couple of changes to the patch since you reviewed.
Namely addin refreshPreview() and using refreshMetaData for a different purpose.
This was needed otherwise the patch introduced a bug.
| src/panels/information/informationpanel.cpp | ||
|---|---|---|
| 212 ↗ | (On Diff #54402) | This looks like an unrelated cosmetic change that could go in another commit. |
| src/panels/information/informationpanelcontent.cpp | ||
| 177–186 ↗ | (On Diff #54402) | Unrelated whitespace changes. |
| 200 ↗ | (On Diff #54402) | Unrelated whitespace changes. |
| src/panels/information/informationpanelcontent.h | ||
| 77 ↗ | (On Diff #54402) | Please add documentation for this method. |
| 84–87 ↗ | (On Diff #54402) | Please update the documentation, as refreshMetaData() won't refresh the visibility of the metadata anymore after this patch. |
Comment Actions
Please push to the 19.04 branch. Thanks!
| src/panels/information/informationpanelcontent.cpp | ||
|---|---|---|
| 177–186 ↗ | (On Diff #54402) | Ah you're right, the phabricator UI confused me :/ |