Fifteen-clock's configuration window is ported to QQC2 and Kirigami.FormLayout. Setting are reorganized in a way that makes more sends. Enabled properties have also been added because some options are irrelevant when others are used.
Diff Detail
- Repository
- R114 Plasma Addons
- Branch
- modernize-15clock-settings (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 9645 Build 9663: arc lint + arc unit
+1 for porting to Kirigami.Formlayout, but I'm not sure that the new layout is an improvement. Something about it just doesn't feel quite right to me.
This might be a case where we could benefit from using actual headers ("Numbers" and "Pieces"), maybe?
So something like this?
But TBH I don't like how Kirigami section headings are positioned (how left they are) when using FormData.label. They also probably get extended much more with German translations. It's nicer IMO when using labels in a row layout instead:
I'm not sure - the sections are so small the headings make it sound redundant (Numbers, Show numbers, Number color), I'd add spaces instead.
Size: 4
[checkbox] Show numbers
Number color:
Piece color:
[checkbox] Use custom image for pieces
--path--
Implicit could work (Numbers --- Show? Color?) but explicit might be better.
Oh whoops, I had completely forgotten that you already had this revision open, sorry :(