Shows the a preview of the configured filename template on the save settings page. I'm not sure about the placement of the label but the functionality should be there. This also again includes a small refactor to access the placeholder replacement from outside of the ExportManager.
BUG: 381175
Details
Details
Diff Detail
Diff Detail
- Repository
- R166 Spectacle
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Overall nice idea
| src/Gui/SettingsDialog/SaveOptionsPage.cpp | ||
|---|---|---|
| 216 | Not sure about the explicit label "Preview of filename" | |
| src/Gui/SettingsDialog/SaveOptionsPage.cpp | ||
|---|---|---|
| 216 | "Filename preview" Also, let's format the filename in a monospaced font. Here's how you'd do that: xi18nc("@info", "Preview of filename: <filename>%1.%2</filename>", filename, mSaveImageFormat->currentText().toLower()) | |
Comment Actions
Very nice !
I would suggest you to position the preview right below the filename field, above the placeholder section.
It would make it visually clearer what it is for and easier to use.
Comment Actions
I'm thinking of dropping the "Filename" now and just having "Preview:". For comparison:
Comment Actions
I'm thinking of dropping the "Filename" now and just having "Preview:". For comparison:
I would be in favor as well since the context is clear now the preview is near the pattern.
Comment Actions
You could even make Preview: a left label in the formlayout, so everything would align nicely. :)
Comment Actions
Looks good! Just one little thing...
| src/Gui/SettingsDialog/SaveOptionsPage.h | ||
|---|---|---|
| 59 | Indentation | |
| src/Gui/SettingsDialog/SaveOptionsPage.cpp | ||
|---|---|---|
| 126 | One more thing I missed, sorry: you don't need to add a space after the colon in the string. The formLayout ensures that there's adequate space automatically (and keeps all the colons aligned vertically). | |