Fix Minimap with QtCurve style
ClosedPublic
Actions

Authored by sars on Mar 14 2019, 5:00 PM.

Details

Reviewers

Commits

R39:2b53012b3b50: Fix Minimap with QtCurve style

Summary

The handle of the scrollbar in QtCurve is much smaller than the scrollbar width when the minimap is on and does not fill the whole width.

This patch moves to always have the scrollbar-handle use the whole width (-2 pixels)

Test Plan

No visual difference with Breeze and with QtCurve the minimap scrollbar handle now uses the whole width of the scrollbar.

Repository

R39 KTextEditor

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

sars requested review of this revision.Mar 14 2019, 5:00 PM

Looks sensible, and I think I've even seen this bug already somewhere.

This revision is now accepted and ready to land.Mar 30 2019, 12:26 AM

This revision was automatically updated to reflect the committed changes.

Yes I also have a memory that there was a bug report about it, but I can't find it now....

Thanks for the fix.

			Path	Packages
M			src/view/kateviewhelpers.cpp (7 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	53895			Mar 14 2019, 4:46 PM	★	★
Diff 2	55057	186b485	R39:2b53012b3b50cb0994be9af55da53b8c5d26e8ea	Mar 30 2019, 9:23 AM	★	★