[knewstuff] make it compile without foreach
ClosedPublic
Actions

Authored by mlaurent on Mar 11 2019, 7:08 AM.

Details

Reviewers

Commits

Summary

compile without foreach

Test Plan

autotest ok

Repository

R304 KNewStuff

Branch

compile_without_foreach (branched from master)

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 9465
Build 9483: arc lint + arc unit

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

mlaurent requested review of this revision.Mar 11 2019, 7:08 AM

This revision is now accepted and ready to land.Mar 11 2019, 12:05 PM

Looks good to me... None of the scary ones that'll trigger various nasty side effects as far as i can tell.

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			CMakeLists.txt (1 line)
M			autotests/kmoretools/kmoretoolstest.cpp (6 lines)
M			autotests/kmoretools/kmoretoolstest2.cpp (6 lines)
M			src/attica/atticaprovider.cpp (20 lines)
M			src/core/cache.cpp (4 lines)
M			src/core/engine.cpp (22 lines)
M			src/core/entryinternal.cpp (2 lines)
M			src/core/installation.cpp (9 lines)
M			src/downloadwidget.cpp (4 lines)
M			src/kmoretools/kmoretools.cpp (18 lines)
M			src/kmoretools/kmoretools_p.h (10 lines)
M			src/kmoretools/kmoretoolsconfigdialog_p.cpp (2 lines)
M			src/kmoretools/kmoretoolsmenufactory.cpp (2 lines)
M			src/kmoretools/kmoretoolspresets.cpp (2 lines)
M			src/qtquick/quickitemsmodel.cpp (4 lines)
M			src/staticxml/staticxmlprovider.cpp (2 lines)
M			src/ui/entrydetailsdialog.cpp (3 lines)
M			src/ui/itemsgridviewdelegate.cpp (3 lines)
M			src/ui/itemsviewdelegate.cpp (3 lines)
M			src/upload/atticahelper.cpp (15 lines)
M			src/uploaddialog.cpp (4 lines)
M			tests/khotnewstuff.cpp (3 lines)
M			tests/khotnewstuff_test.cpp (2 lines)
M			tests/kmoretools/kmoretoolstest_interactive.cpp (7 lines)