My change in 304528e80b935efea05e2d5e3030266e0eddc44c has been reported to
cause issues for PostMarketOS https://gitlab.com/postmarketOS/pmaports/issues/204
I originally submitted the change to activate Framebuffer devices
as secondary framebuffer devices are not on by default, (such as a
secondary DisplayLink device). Changing attributes usually forced
some framebuffer devices to turn on, however I have found a more
accurate way to turn on framebuffer devices, without messing with
the color layout.
Details
Details
- Reviewers
davidedmundson graesslin zzag - Group Reviewers
KWin - Commits
- R108:93b7eea67db4: [platforms/fbdev] Use a better way to correct activating framebuffer devices
Diff Detail
Diff Detail
- Repository
- R108 KWin
- Branch
- master
- Lint
Lint OK - Unit
No Unit Test Coverage - Build Status
Buildable 9455 Build 9473: arc lint + arc unit
Comment Actions
bluescreenavenger@gmail.com
I was able to get a previous commit in without my full name. I just don't want it to appear in Google...
Comment Actions
I won't strongly insist on this but it would be great if you could provide your real name for better git history. For example, if there is commit whose author is "vlad <....>", the only thing that comes to mind: Vlad? Which one? It makes KWin's git policy questionable.
Comment Actions
I think there's no problem with anonymous contributions. We have no means to check anyway if the provided name is correct.
Comment Actions
Well, it's just for better git history. As I said previously, I won't insist on this (though it would be great to have full name :-)). The most important part is email anyway.
Comment Actions
I gave the alias of
Nerdopolis Turfwalker
for the previous commit I made that broke it, so can we go with that for consistency I guess?
email address is
bluescreenavenger@gmail.com
Comment Actions
Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Using frame buffer device: "/dev/fb0" Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Failed to open frame buffer device: "/dev/fb0" through logind, trying without Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Bits Per Pixel: 24 Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Buffer Length: 6266880 Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Bytes Per Line: 3264 Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Alpha Length: 0 Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Red Length: 8 Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Green Length: 8 Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Blue Length: 8 Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Blue Offset: 0 Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Green Offset: 8 Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Red Offset: 16 Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Alpha Offset: 0 Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Framebuffer Format is RGB888 Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_core: Compositing forced to QPainter mode by environment variable
Tested this, seems to work! No more blue screen and bits_per_pixel value is correct. Colors looks incorrect (red swapped with blue, visible on angelfish icon), but this may be problem with my device framebuffer driver, need to debug more...