Fix build with cmake < 3.7
ClosedPublic

Authored by wbauer on Mar 7 2019, 8:16 AM.

Details

Summary

VERSION_GREATER_EQUAL requires cmake 3.7 or higher, but the minimum version supported by KDE Frameworks is 3.5.
So use NOT VERSION_LESS instead, which is logically equivalent and also
works with older cmake versions.

Test Plan

Builds fine with cmake 3.5.2 now.
Before, I got this cmake error:

CMake Error at data/CMakeLists.txt:69 (if):
  if given arguments:

    "3.5.2" "VERSION_GREATER_EQUAL" "3.13.0"

  Unknown arguments specified

Still builds fine with newer cmake versions, tested with 3.10.2 and 3.13.4.

Diff Detail

Repository
R216 Syntax Highlighting
Lint
Lint Skipped
Unit
Unit Tests Skipped
wbauer created this revision.Mar 7 2019, 8:16 AM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptMar 7 2019, 8:16 AM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
wbauer requested review of this revision.Mar 7 2019, 8:16 AM
vkrause accepted this revision.Mar 7 2019, 8:23 AM
This revision is now accepted and ready to land.Mar 7 2019, 8:23 AM
This revision was automatically updated to reflect the committed changes.