Without this, diagonal lines are aliased and many images look terrible.
Details
- Reviewers
broulik davidedmundson - Group Reviewers
Plasma - Commits
- R114:4665d0b41aac: [Media Frame] Set sourceSize for higher quality and lower memory consumption
Before:
After:
Slideshow transitions still work.
Performance still seems good in a crappy VM with 2 GB RAM and software rendering only.
Diff Detail
- Repository
- R114 Plasma Addons
- Branch
- use-mipmapping-for-higher-quality (branched from Plasma/5.15)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 9221 Build 9239: arc lint + arc unit
Would it be better to set the sourceSize? If we're downscaling during rendering we're wasting memory
applets/mediaframe/package/contents/ui/main.qml | ||
---|---|---|
189 | Note that this will cause the image to be reloaded everytime the size changes, so make sure the image isn't loaded repeatedly on start (as the applet is laid out) and/or while resizing the widget |
Set sourceSize in a timer so we don't continuously reload the image while the widget is being resized
applets/mediaframe/package/contents/ui/main.qml | ||
---|---|---|
215–216 | Maybe restart is better, you can resize more than a second, so it'll wait a timer interval with no resize activity. After that you can make timer.interval say 100 ms. |
Restart the timer when resizing is still ongoing so we can reduce the timer interval and update faster once resizing is done
applets/mediaframe/package/contents/ui/main.qml | ||
---|---|---|
183 | Isn't this doing the opposite of the comment and /always/ reloading an image after 250ms with a new source size? |