Add UDev find module
ClosedPublic

Authored by vkrause on Mar 3 2019, 9:26 AM.

Details

Summary

This one is originally coming from Solid, but there are several more copies
in our repositories (plasma-desktop, kwin, powerdevil, etc).

Diff Detail

Repository
R240 Extra CMake Modules
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 9113
Build 9131: arc lint + arc unit
vkrause created this revision.Mar 3 2019, 9:26 AM
Restricted Application added projects: Frameworks, Build System. · View Herald TranscriptMar 3 2019, 9:26 AM
Restricted Application added subscribers: kde-buildsystem, kde-frameworks-devel. · View Herald Transcript
vkrause requested review of this revision.Mar 3 2019, 9:26 AM

We probably need to set uppercase variables for the moment. plasma-desktop and powerdevil include the ECM modules dir before their local copy, so any older release would fail to build with ECM >= 5.57

find-modules/FindUDev.cmake
24

Since 5.57

We probably need to set uppercase variables for the moment. plasma-desktop and powerdevil include the ECM modules dir before their local copy, so any older release would fail to build with ECM >= 5.57

Just tested. powerdevil fails to link and HAVE_UDEV is #undef'ed in config-keyboard.h from plasma-desktop. We need compat variables until KF6.

vkrause updated this revision to Diff 53055.Mar 3 2019, 10:38 AM

Add backward compatibility variables.

cgiboudeaux accepted this revision.Mar 3 2019, 10:53 AM
cgiboudeaux added inline comments.
find-modules/FindUDev.cmake
87

mark_as_advanced(UDEV_FOUND UDEV_LIBS UDEV_INCLUDE_DIR)

This revision is now accepted and ready to land.Mar 3 2019, 10:53 AM
This revision was automatically updated to reflect the committed changes.