Differential D19418

Make it compiles without deprecated method
Needs RevisionPublic
Actions

Authored by mlaurent on Feb 28 2019, 12:56 PM.

Details

Reviewers
dfaure
apol
broulik
Commits
R242:9fc663d9f0ed: Make it compiles without deprecated method
Summary

compile without deprecated method

Test Plan

all autotest ok

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mlaurent created this revision.Feb 28 2019, 12:56 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 28 2019, 12:56 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
mlaurent requested review of this revision.Feb 28 2019, 12:56 PM
apol accepted this revision.Feb 28 2019, 4:43 PM
This revision is now accepted and ready to land.Feb 28 2019, 4:43 PM
Closed by commit R242:9fc663d9f0ed: Make it compiles without deprecated method (authored by mlaurent). · Explain WhyFeb 28 2019, 10:01 PM
This revision was automatically updated to reflect the committed changes.
broulik reopened this revision.Mar 12 2019, 7:51 AM
broulik added a subscriber: broulik.
broulik added inline comments.
src/declarativeimports/core/datamodel.cpp
67

Likely culprit here, sourceModel() being null

This revision is now accepted and ready to land.Mar 12 2019, 7:51 AM
broulik requested changes to this revision.Mar 12 2019, 7:51 AM
This revision now requires changes to proceed.Mar 12 2019, 7:51 AM

Showing Only Differences

This revision modifies 17 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

Diff 52862

View Options

src/declarativeimports/core/datamodel.cpp

Loading...