Differential D19414

[wayland] Implement maximize rules
ClosedPublic
Actions

Authored by zzag on Feb 28 2019, 12:22 PM.

Details

Reviewers
davidedmundson
Group Reviewers
KWin
Commits
R108:702a4ff68877: [wayland] Implement maximize rules
Summary

CCBUG: 409797

Test Plan

The new tests pass.

Diff Detail

Repository
R108 KWin
Branch
implement-size-position-rules
Lint
Lint ErrorsExcuse: cppcheck is lame
SeverityLocationCodeMessage
Errorautotests/integration/shell_client_rules_test.cpp:403CppcheckdoubleFree
Errorautotests/integration/shell_client_rules_test.cpp:404CppcheckdoubleFree
Errorautotests/integration/shell_client_rules_test.cpp:480CppcheckdoubleFree
Errorautotests/integration/shell_client_rules_test.cpp:481CppcheckdoubleFree
Errorautotests/integration/shell_client_rules_test.cpp:538CppcheckdoubleFree
Errorautotests/integration/shell_client_rules_test.cpp:539CppcheckdoubleFree
Errorautotests/integration/shell_client_rules_test.cpp:675CppcheckdoubleFree
Errorautotests/integration/shell_client_rules_test.cpp:676CppcheckdoubleFree
Errorautotests/integration/shell_client_rules_test.cpp:1942CppcheckdoubleFree
Errorautotests/integration/shell_client_rules_test.cpp:1943CppcheckdoubleFree
Errorautotests/integration/shell_client_rules_test.cpp:1995CppcheckdoubleFree
Errorautotests/integration/shell_client_rules_test.cpp:1996CppcheckdoubleFree
Errorautotests/integration/shell_client_rules_test.cpp:2052CppcheckdoubleFree
Errorautotests/integration/shell_client_rules_test.cpp:2053CppcheckdoubleFree
Errorautotests/integration/shell_client_rules_test.cpp:2170CppcheckdoubleFree
Errorautotests/integration/shell_client_rules_test.cpp:2171CppcheckdoubleFree
Errorautotests/integration/shell_client_rules_test.cpp:2253CppcheckdoubleFree
Errorautotests/integration/shell_client_rules_test.cpp:2254CppcheckdoubleFree
Errorautotests/integration/shell_client_rules_test.cpp:2299CppcheckdoubleFree
Errorautotests/integration/shell_client_rules_test.cpp:2300CppcheckdoubleFree
Errorautotests/integration/shell_client_rules_test.cpp:2347CppcheckdoubleFree
Errorautotests/integration/shell_client_rules_test.cpp:2348CppcheckdoubleFree
Errorautotests/integration/shell_client_rules_test.cpp:2441CppcheckdoubleFree
Errorautotests/integration/shell_client_rules_test.cpp:2442CppcheckdoubleFree
Errorautotests/integration/shell_client_rules_test.cpp:2521CppcheckdoubleFree
Unit
No Unit Test Coverage
Build Status
Buildable 8976
Build 8994: arc lint + arc unit
zzag created this revision.Feb 28 2019, 12:22 PM
Restricted Application added a project: KWin. · View Herald TranscriptFeb 28 2019, 12:22 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Feb 28 2019, 12:22 PM
zzag updated this revision to Diff 52843.Feb 28 2019, 4:28 PM

use enums in the tests

davidedmundson accepted this revision.Mar 8 2019, 12:18 AM
This revision is now accepted and ready to land.Mar 8 2019, 12:18 AM
zzag updated this revision to Diff 61439.Jul 9 2019, 6:21 PM

Adjust the patch to recent ShellClient changes.

zzag updated this revision to Diff 61443.Jul 9 2019, 6:37 PM

Rebase.

ngraham edited the summary of this revision. (Show Details)Jul 15 2019, 2:32 AM
zzag edited the summary of this revision. (Show Details)Jul 15 2019, 9:35 AM
Closed by commit R108:702a4ff68877: [wayland] Implement maximize rules (authored by zzag). · Explain WhyJul 29 2019, 6:21 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 52811

View Options

autotests/integration/shell_client_rules_test.cpp

Loading...
View Options

geometry.cpp

Loading...
View Options

shell_client.cpp

Loading...
View Options

workspace.cpp

Loading...