| davidedmundson |
| KWin |
Currently, the test doesn't verify that each rule does what it should,
e.g. a force rule is a force rule and not force temporarily, etc. This
as it turns out hides some bugs, e.g. all remember rules do not work,
forced window shortcuts can't be released, etc.
CCBUG: 403305
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
Add explanation for why testShortcutRemember, testShortcutForce, and
testShortcutForceTemporarily should be skipped.
| autotests/integration/shell_client_rules_test.cpp | ||
|---|---|---|
| 186 | I don't really understand this. Before we had a test which tested the aspects already supported. For every added supported rule the test was added. Obviously this was not complete, it's not news that rules are fully implemented yet. Now we have more test cases also for the things not yet supported, but the complete test is skipped. Thus also the already working aspects are not covered. I don't understand what the advantage is. | |
Once this change is rebased on David's change, I'll have to tweak createWindow helper.
| autotests/integration/shell_client_rules_test.cpp | ||
|---|---|---|
| 1096 | Can we expose the enums as public and use them here. | |
| autotests/integration/shell_client_rules_test.cpp | ||
|---|---|---|
| 1096 | Yeah, it's a very good idea. Whould it be enough to expose only // All these values are saved to the cfg file, and are also used in kstart! enum { Unused = 0, DontAffect, // use the default value Force, // force the given value Apply, // apply only after initial mapping Remember, // like apply, and remember the value when the window is withdrawn ApplyNow, // apply immediatelly, then forget the setting ForceTemporarily // apply and force until the window is withdrawn }; ? | |
| autotests/integration/shell_client_rules_test.cpp | ||
|---|---|---|
| 1096 | And StringMatch | |