The relevant preview we need to do is see how the blur looks over a near completely black and a near completely white image.

In D19409#421790, @davidedmundson wrote:

The relevant preview we need to do is see how the blur looks over a near completely black and a near completely white image.

Nearly entirely but not entirely white/black?

How's this

• dark:

• bright:

In D19409#421832, @rooty wrote:

In D19409#421790, @davidedmundson wrote:

The relevant preview we need to do is see how the blur looks over a near completely black and a near completely white image.

Nearly entirely but not entirely white/black?

I was actually going to ask the same. Find some pretty dark wallpaper and a very light one (e.g. snowscape) so we test it with those backgrounds. Wouldn't be bad if you could also find some ultra busy backgrounds.

Otherwise this does look much better.

Looks readable.
No objections from me.

In D19409#421894, @ngraham wrote:

Huge improvement. Don't forget to change the preview images in lookandfeel/contents/previews/ though!

Also this fixes https://bugs.kde.org/show_bug.cgi?id=398963.

Sure thing.
What do I put the fixed in version as?

5.16.0 since this will be landing in master.

Should we keep the UserDelegate.qml shadow then? Because it doesn't seem necessary considering the blur's here to stay.

P.S. What happens to the blur if sddm defaults to software rendering?

EDIT: I know I just landed it but there was also the clock shadow there and I really like that new clock shadow :D

1996? 😆

Also the lock screen has a preview image too: plasma-workspace/lookandfeel/contents/previews/lockscreen.png

In D19409#422203, @rooty wrote:

Should we keep the UserDelegate.qml shadow then? Because it doesn't seem necessary considering the blur's here to stay.

P.S. What happens to the blur if sddm defaults to software rendering?

EDIT: I know I just landed it but there was also the clock shadow there and I really like that new clock shadow :D

TBH I kind of like the shadows on top of the blur--especially with your new much nicer-looking shadows!

When SDDM uses software rendering, the shadow disappears unless we specifically handle that case and draw an outline instead.

In D19409#422264, @ngraham wrote:

1996? 😆

https://kde.org/announcements/announcement.php (wasn't sure about the date I was sure it was 1996 tho :D)
It seemed preferable to some random date

Didn't know about the lock screen preview image... interesting

TBH I kind of like the shadows on top of the blur--especially with your new much nicer-looking shadows!

When SDDM uses software rendering, the shadow disappears unless we specifically handle that case and draw an outline instead.

In that case, we should consider adding action button label shadows as well.
I wasn't asking about the shadows though, I was asking about what happens to the blur if sddm uses software rendering - because if the software rendered version's blurry too, we might not need a text outline at all.

P.S. The time stands for a very important date too :D

In D19409#422203, @rooty wrote:

Should we keep the UserDelegate.qml shadow then? Because it doesn't seem necessary considering the blur's here to stay.

I think they're unnecessary. There's also a bug they cause in 5.15:

In D19409#422361, @filipf wrote:

In D19409#422203, @rooty wrote:

Should we keep the UserDelegate.qml shadow then? Because it doesn't seem necessary considering the blur's here to stay.

I think they're unnecessary. There's also a bug they cause in 5.15:

Ouch, nasty bug

In D19409#422453, @rooty wrote:

In D19409#422361, @filipf wrote:

In D19409#422203, @rooty wrote:

Should we keep the UserDelegate.qml shadow then? Because it doesn't seem necessary considering the blur's here to stay.

I think they're unnecessary. There's also a bug they cause in 5.15:

Ouch, nasty bug

Yeah, even if you make the shadow color backgroundColor again it's not good to have white "shadows":

Yeah, that doesn't look great. :/

For elements like the actionbuttons and the username that will always appear over a blur, I guess we should abandon the text shadows. For the clock that sometimes has a shadow, what we should probably do is make the shadow's opacity property public (defaulting to 0.0) and have only the lock screen turn it on when there's no blur. Then when the UI controls and blur appear, it can set that to off. Then you can add an opacity animator to the clock itself so that the shadows's visibility animates when turned on and off.

In D19409#422572, @ngraham wrote:

Yeah, that doesn't look great. :/

For elements like the actionbuttons and the username that will always appear over a blur, I guess we should abandon the text shadows. For the clock that sometimes has a shadow, what we should probably do is make the shadow's opacity property public (defaulting to 0.0) and have only the lock screen turn it on when there's no blur. Then when the UI controls and blur appear, it can set that to off. Then you can add an opacity animator to the clock itself so that the shadows's visibility animates when turned on and off.

Should I make all of that part of the same patch?

Let's do that separately.

Okay, then I'll just update the preview here seeing as there's nothing else to be done here

You know, it occurs to me that we should probably change the previews after we're done with all of this, or else each patch will need its own adjusted preview images! Sorry to have steered you wrong there. Remove the preview change and let's get this landed! Such a big improvement.

In D19409#422811, @ngraham wrote:

You know, it occurs to me that we should probably change the previews after we're done with all of this, or else each patch will need its own adjusted preview images! Sorry to have steered you wrong there. Remove the preview change and let's get this landed! Such a big improvement.

Haha sure thing, we can just submit a final patch with all the previews?

If you wish to play with login and lock screen stuff, go to

Main Login

/usr/share/sddm/themes/your-login-theme/main.qml

Lock Screen Login

Helps to know that breeze is the default Plasma lock screen theme. If a lock screen is not part of whatever theme you are using, then Plasma will use the breeze one.

/usr/share/plasma/look-and-feel/org.kde.breeze.desktop/contents/lockscreen/LockScreenUi.qml

In both of those files you will find something like this (I have added the corrections):

WallpaperFader {

    // visible: false keeps from fading the wallpaper
    visible: false
    
    // Commenting out "anchors.fill: parent" will also do it.
    //anchors.fill: parent

    state: lockScreenRoot.uiVisible ? "on" : "off"
    source: wallpaper
    mainStack: mainStack
    footer: footer
    clock: clock
}

Either one of those corrections will do the trick. I don't like blurred backgrounds on my login screens. They particularly look bad if they are already dark pictures.

Anyway, good luck.