remove kpackage_install_package deprecation warning
ClosedPublic

Authored by sitter on Feb 27 2019, 11:09 AM.

Details

Summary

an ad-hoc discussion on #plasma-devel suggests the science isn't quite in
on whether RCCs are in fact always better.
on the one hand simple profiling suggested for plasma use cases it may be
ever so slightly faster in cold boot scenario. on the other hand the
actual rcc code supposedly is fairly inefficient in how it access the
disk and manages memory.

this currently puts us in a situation where rcc and !rcc may be viable
depending on the specific scenario of a package. (depending on disk type,
size of rcc, loading, ram constraints, operating system).

if someone wants to see rcc be default it's likely that improvements need
to be made to Qt first. in any event actually getting some solid profiling
before deprecation would be greatly appreciated. is rcc always better?
why is it better? if it isn't always, what are the criteria that make it
preferred over flat files? does the disk type (rotating/!rotating) matter?
etc. etc.

Test Plan
  • cmake && make pass
  • plasma-pa no longer raises deprecation warnings

Diff Detail

Repository
R290 KPackage
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sitter created this revision.Feb 27 2019, 11:09 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 27 2019, 11:09 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
sitter requested review of this revision.Feb 27 2019, 11:09 AM
mart accepted this revision.Feb 27 2019, 11:11 AM
This revision is now accepted and ready to land.Feb 27 2019, 11:11 AM
This revision was automatically updated to reflect the committed changes.
apol added a subscriber: apol.Feb 28 2019, 4:30 PM

I'd like to see this documented somewhere.

apol added a comment.Feb 28 2019, 4:31 PM
In D19383#422019, @apol wrote:

I'd like to see this documented somewhere.

My bad, thanks @sitter :)