Add support for major version related pot file generating
Needs RevisionPublic

Authored by habacker on Feb 25 2019, 3:04 PM.

Diff Detail

Branch
svn+ssh://svn@svn.kde.org/home/kde/trunk/l10n-kde4
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 8825
Build 8843: arc lint + arc unit
habacker requested review of this revision.Feb 25 2019, 3:04 PM
habacker created this revision.

What is the use case that you are trying to achieve?
If the version is something like the Qt version, then this is a non-starter.
Version-specific translations should be tracked and managed in different translations branches. If a program support different branches with the same codebase, it's up to its codebase to support the same translation file.

habacker edited reviewers, added: pino; removed: Localization, sdepiets.Feb 26 2019, 10:22 PM

What is the use case that you are trying to achieve?

In extract-messages.sh there are specific XGETTEXT macros for a specific scope like XGETTEXT_QT for scanning Qt translations or XGETTEXT_WWW for another purpose. The new macros XGETTEXT_KDE4 and XGETTEXT_KF5 provides additional scopes limiting to a specific KDE/KF major version number.

If the version is something like the Qt version, then this is a non-starter.

no, it's KDE/KF major version

Version-specific translations should be tracked and managed in different translations branches.

Which has the drawback that they tend to diverge, which is not wanted with alkimia.

If a program support different branches with the same codebase, it's up to its codebase to support the same translation file.

In alkimia case there are the library itself and the online quote editor, which are multi branch. plasma/applets/onlinequote currently is KDE4 only and plasma/applets/ForeignCurrencies KF5 only.
The new macros are exactly for this purpose and are used in the projects Message.sh to only process the pot files intended for the given major version (see D19304).

Without this macros plasma/applets/onlinequote will be updated in l10n-kf5 without really been used and plasma/applets/ForeignCurrencies would be updated in the l10n-kde4 also without been used.

Right now everything is only extracted into l10n-kf5. Both po files will be part of the tarball of the library, so they will be used.

There is no really an issue in extracting both of them, and anyway we don't apply code which specific to a major version in the code; the branch code is already enough to differentiate.

There is no need for this change.

ltoscano requested changes to this revision.Feb 26 2019, 10:29 PM
ltoscano added subscribers: Localization, aacid.

(Requesting changes, but this is really a request to abandon this.)

This revision now requires changes to proceed.Feb 26 2019, 10:30 PM

Yes, this is unwanted.