libtaskmanager/xwindowtasksmodel.cpp
790–792	What if the center of the window is not on any screen? Yes that's possible. KWin's implementation calculates the distance to every screen and uses the minimal distance as the screen it's on. Relevant methods to look at: Toplevel::checkScreen (in toplevel.cpp) and Screens::number in screens.cpp

This revision now requires changes to proceed.Jun 17 2016, 6:02 AM

Fall back to the screen frameGeometry().center() is closest to.

hein marked an inline comment as done.Jun 17 2016, 7:02 AM

hein added inline comments.

libtaskmanager/xwindowtasksmodel.cpp
790–792	Fixed.

Make it not uncompilable nonsense.

graesslin edited edge metadata.

This revision is now accepted and ready to land.Jun 17 2016, 7:17 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			libtaskmanager/xwindowtasksmodel.cpp (21 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	4565	2e3e508		Jun 16 2016, 11:01 PM	★	★
Diff 2	4570	2e3e508	Fall back to the screen frameGeometry().center() is closest to.	Jun 17 2016, 7:01 AM	★	★
Diff 3	4571	2e3e508	Make it not uncompilable nonsense.	Jun 17 2016, 7:06 AM	★	★
Diff 4	4578	7eff45a	rPLASMAWORKSPACE3b1618c5590b85785d84a7d27787ba43ef7486b2	Jun 17 2016, 8:00 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
c792d0fc1af2	e8485d73e02a	2e3e508fb1f5	Eike Hein	Improve window-on-screen intersection test. (Show More…)	Jun 16 2016, 10:59 PM

Diff 4571