[Task Manager] Fix virtual desktops subtext on task tooltip

Authored by hein on Feb 23 2019, 4:59 PM.


Diff Detail

R119 Plasma Desktop
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
hein created this revision.Feb 23 2019, 4:59 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 23 2019, 4:59 PM
hein requested review of this revision.Feb 23 2019, 4:59 PM
Fuchs added a subscriber: Fuchs.Feb 23 2019, 5:26 PM

Yep, that works here, even with groups spanning multiple desktops. Thanks for the quick fix!

Fuchs added a comment.EditedFeb 23 2019, 5:33 PM

One minor nitpick: if it is on all virtual desktops there is no text shown, related to virtual desktops, maybe some "is on all virtual desktops" or so would be nice, for consistency.

But it might entirely be that it didn't do that before either, at least the code looks like it. Also this would introduce a new string to translate.
Maybe in a second patch?

apol added a subscriber: apol.Feb 24 2019, 12:00 AM
apol added inline comments.

I think you should be using !== and === on these comparisons as you don't expect casts.

mart accepted this revision.Mar 4 2019, 11:38 AM
This revision is now accepted and ready to land.Mar 4 2019, 11:38 AM
This revision was automatically updated to reflect the committed changes.