BUG:404706
Details
Details
- Reviewers
mart - Group Reviewers
Plasma - Commits
- R119:d769b7aa8838: [Task Manager] Fix virtual desktops subtext on task tooltip
Diff Detail
Diff Detail
- Repository
- R119 Plasma Desktop
- Branch
- Plasma/5.15
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 8738 Build 8756: arc lint + arc unit
Comment Actions
Yep, that works here, even with groups spanning multiple desktops. Thanks for the quick fix!
Comment Actions
One minor nitpick: if it is on all virtual desktops there is no text shown, related to virtual desktops, maybe some "is on all virtual desktops" or so would be nice, for consistency.
But it might entirely be that it didn't do that before either, at least the code looks like it. Also this would introduce a new string to translate.
Maybe in a second patch?
applets/taskmanager/package/contents/ui/Task.qml | ||
---|---|---|
370 | I think you should be using !== and === on these comparisons as you don't expect casts. |